Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1139823003: [Files.app] disable slow tests on Debug build, ASAN, MSAN, TSAN bots as a whole (Closed)

Created:
5 years, 7 months ago by yoshiki
Modified:
5 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] disable slow tests on Debug build, ASAN, MSAN, TSAN bots as a whole The all slow tests have a possibility to be failed on slow bots (Debug build, ASAN, MSAN, TSAN bots). So this patch disabled them as a whole by defining DISABLE_SLOW_FILESPAPP_TEST macro. BUG=none TEST=run Debug, ASAN, MSAN, TSAN bots Committed: https://crrev.com/975a272494771e862aec2d15802008cf68d91bf9 Cr-Commit-Position: refs/heads/master@{#329815}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -92 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 31 chunks +65 lines, -92 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@hirono PTAL. Thanks.
5 years, 7 months ago (2015-05-14 06:10:01 UTC) #2
hirono
lgtm. Thank you fixing this!
5 years, 7 months ago (2015-05-14 06:31:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823003/1
5 years, 7 months ago (2015-05-14 06:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 06:54:27 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 06:55:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/975a272494771e862aec2d15802008cf68d91bf9
Cr-Commit-Position: refs/heads/master@{#329815}

Powered by Google App Engine
This is Rietveld 408576698