Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 1139823002: [Telemetry] Remove page_test.DidRunActions hook. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan, dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove page_test.DidRunActions hook. Merge this with DidNavigateToPage since they are called and essentially called in the same time (after page.Navigate & before page.RunPageInteractions) BUG=455391, 470147 Committed: https://crrev.com/aff97668c8925e0fea5c567e2361f3c8c4f7c12e Cr-Commit-Position: refs/heads/master@{#329292}

Patch Set 1 #

Patch Set 2 : Remove WillRunTests in telemetry/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M tools/perf/measurements/oilpan_gc_times.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/measurements/thread_times.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 2 chunks +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr.py View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 2 chunks +3 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/smooth_gesture_util_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
nednguyen
5 years, 7 months ago (2015-05-11 20:43:53 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-11 20:46:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823002/1
5 years, 7 months ago (2015-05-11 20:54:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823002/20001
5 years, 7 months ago (2015-05-11 21:13:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) win_perf_bisect on ...
5 years, 7 months ago (2015-05-11 23:16:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139823002/20001
5 years, 7 months ago (2015-05-12 00:09:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 00:24:25 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:25:48 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aff97668c8925e0fea5c567e2361f3c8c4f7c12e
Cr-Commit-Position: refs/heads/master@{#329292}

Powered by Google App Engine
This is Rietveld 408576698