Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: utils/apidoc/html_diff.dart

Issue 11398002: Splitting SVG types out of dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Passing dartc. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/html/svgelement2_test.dart ('K') | « utils/apidoc/apidoc.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/apidoc/html_diff.dart
diff --git a/utils/apidoc/html_diff.dart b/utils/apidoc/html_diff.dart
index 130666d2b9ae9e76aadf69c60c7fcd2856bc5c62..0c4d1eef5ed2ac5edc3e6fc54793cba8d3ec515a 100644
--- a/utils/apidoc/html_diff.dart
+++ b/utils/apidoc/html_diff.dart
@@ -19,8 +19,8 @@ import '../../sdk/lib/_internal/compiler/implementation/mirrors/mirrors_util.dar
// TODO(amouravski): There is currently magic that looks at dart:* libraries
// rather than the declared library names. This changed due to recent syntax
// changes. We should only need to look at the library 'html'.
-const HTML_LIBRARY_NAME = 'dart:html';
-const HTML_DECLARED_NAME = 'html';
+const List<String> HTML_LIBRARY_NAMES = const ['dart:html', 'dart:svg'];
+const List<String> HTML_DECLARED_NAMES = const ['html', 'svg'];
/**
* A class for computing a many-to-many mapping between the types and
@@ -72,8 +72,11 @@ class HtmlDiff {
* calling [HtmlDiff.run].
*/
static void initialize(Path libDir) {
- _compilation = new Compilation.library(<Path>[new Path(HTML_LIBRARY_NAME)],
- libDir);
+ var paths = <Path>[];
+ for (var libraryName in HTML_LIBRARY_NAMES) {
+ paths.add(new Path(libraryName));
+ }
+ _compilation = new Compilation.library(paths, libDir);
_mirrors = _compilation.mirrors;
}
@@ -96,20 +99,26 @@ class HtmlDiff {
* [HtmlDiff.initialize] should be called.
*/
void run() {
- LibraryMirror htmlLib = _mirrors.libraries[HTML_DECLARED_NAME];
- if (htmlLib === null) {
- warn('Could not find $HTML_LIBRARY_NAME');
- return;
+ for (var libraryName in HTML_DECLARED_NAMES) {
+ var library = _mirrors.libraries[libraryName];
+ if (library == null) {
+ warn('Could not find $libraryName');
+ return;
+ }
+ _processLibrary(library);
}
- for (ClassMirror htmlType in htmlLib.classes.values) {
- final domTypes = htmlToDomTypes(htmlType);
+ }
+
+ void _processLibrary(LibraryMirror library) {
Anton Muhin 2012/11/09 13:13:23 why a helper method? can it be inline or a closur
blois 2012/11/09 18:21:56 Done.
+ for (ClassMirror type in library.classes.values) {
+ final domTypes = htmlToDomTypes(type);
if (domTypes.isEmpty) continue;
- htmlTypesToDom.putIfAbsent(htmlType.qualifiedName,
+ htmlTypesToDom.putIfAbsent(type.qualifiedName,
() => new Set()).addAll(domTypes);
- htmlType.members.forEach(
- (_, m) => _addMemberDiff(m, domTypes));
+ type.members.forEach(
+ (_, m) => _addMemberDiff(m, domTypes, library.simpleName));
}
}
@@ -119,13 +128,14 @@ class HtmlDiff {
* `@domName` type values that correspond to [htmlMember]'s
* defining type.
*/
- void _addMemberDiff(MemberMirror htmlMember, List<String> domTypes) {
+ void _addMemberDiff(MemberMirror htmlMember, List<String> domTypes,
+ String libraryName) {
var domMembers = htmlToDomMembers(htmlMember, domTypes);
if (htmlMember == null && !domMembers.isEmpty) {
- warn('$HTML_LIBRARY_NAME member '
+ warn('$libraryName member '
'${htmlMember.owner.simpleName}.'
'${htmlMember.simpleName} has no corresponding '
- '$HTML_LIBRARY_NAME member.');
+ '$libraryName member.');
}
if (htmlMember == null) return;
« tests/html/svgelement2_test.dart ('K') | « utils/apidoc/apidoc.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698