sdk/lib/html/scripts/systemnative.py - Issue 11398002: Splitting SVG types out of dart:html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/scripts/systemnative.py

Issue 11398002: Splitting SVG types out of dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Passing dartc. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/scripts/systemnative.py

diff --git a/sdk/lib/html/scripts/systemnative.py b/sdk/lib/html/scripts/systemnative.py

index 089ab5aa86ba0fde50b9be7ace435dbf6822babb..e4f3d1db514f6e729bd041a2a80e0374e00f111b 100644

--- a/sdk/lib/html/scripts/systemnative.py

+++ b/sdk/lib/html/scripts/systemnative.py

@@ -231,7 +231,8 @@ class DartiumBackend(HtmlDartGenerator):

INCLUDES=self._GenerateCPPIncludes(self._cpp_impl_includes),

CALLBACKS=self._cpp_definitions_emitter.Fragments(),

RESOLVER=self._cpp_resolver_emitter.Fragments(),

- DART_IMPLEMENTATION_CLASS=self._interface_type_info.implementation_name())

+ DART_IMPLEMENTATION_CLASS=self._interface_type_info.implementation_name(),

+ DART_IMPLEMENTATION_LIBRARY='dart:%s' % self._renamer.GetLibraryName(self._interface))

Anton Muhin 2012/11/09 13:13:23 does it have access to self._library_name?

blois 2012/11/09 18:21:56 It does not.

def _GenerateCPPHeader(self):

to_native_emitter = emitter.Emitter()