Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1139793003: Disable Rotation Animations on Login Pages (Closed)

Created:
5 years, 7 months ago by jonross
Modified:
5 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change is intended to M-43. Currently screen rotation animations expose a bug, causing the login screen to not be useable. Disable rotation animations while a user is not logged in. This will be later reverted on M-44 where a fix to the underlying issue will be landed. TEST=manual testing on device BUG=chrome-os-partner:40118 Committed: https://crrev.com/274e83a41a63c1746203bc1cee8cefd07ae821c9 Cr-Commit-Position: refs/heads/master@{#330100}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M ash/rotator/screen_rotation_animator.cc View 2 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hi Oshima, As a potential alternative to disabling the entire screen rotation animation on M-43, ...
5 years, 7 months ago (2015-05-15 14:10:20 UTC) #3
oshima
lgtm
5 years, 7 months ago (2015-05-15 14:41:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139793003/20001
5 years, 7 months ago (2015-05-15 14:44:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-15 16:02:47 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:03:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/274e83a41a63c1746203bc1cee8cefd07ae821c9
Cr-Commit-Position: refs/heads/master@{#330100}

Powered by Google App Engine
This is Rietveld 408576698