Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1139753003: Revert of Catch Exception for Intent.parseUri instead of URISyntaxException (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Catch Exception for Intent.parseUri instead of URISyntaxException (patchset #2 id:20001 of https://codereview.chromium.org/1132473004/) Reason for revert: broke findbugs: http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/59364 slipped through CQ because analyze in android_clang_dbg_recipe decided it didn't need to compile: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/75301 Original issue's description: > Catch Exception for Intent.parseUri instead of URISyntaxException > > Intent.parseUri can throw other excpetions like NumberFormatException. > So we need to catch Exception to avoid crash. > > BUG=484336 > > Committed: https://crrev.com/e9785bb71f9e0b8a9a3ba321c2c6483c8805e5a1 > Cr-Commit-Position: refs/heads/master@{#329163} TBR=torne@chromium.org,tedchoc@chromium.org,jaekyun@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484336 Committed: https://crrev.com/c74b42e547e3e8dc42e8c4fec1b431bc4c37b0f3 Cr-Commit-Position: refs/heads/master@{#329170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ConnectionInfoPopup.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 6 chunks +7 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbudorick
Created Revert of Catch Exception for Intent.parseUri instead of URISyntaxException
5 years, 7 months ago (2015-05-11 17:19:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139753003/1
5 years, 7 months ago (2015-05-11 17:25:45 UTC) #2
Jaekyun Seok (inactive)
On 2015/05/11 17:25:45, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 7 months ago (2015-05-11 17:29:34 UTC) #3
jbudorick
On 2015/05/11 17:29:34, Jaekyun Seok wrote: > On 2015/05/11 17:25:45, I haz the power (commit-bot) ...
5 years, 7 months ago (2015-05-11 17:30:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 17:34:34 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 17:35:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c74b42e547e3e8dc42e8c4fec1b431bc4c37b0f3
Cr-Commit-Position: refs/heads/master@{#329170}

Powered by Google App Engine
This is Rietveld 408576698