Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1139743004: cc: Reland "Add UMA stats for record and raster time." (Closed)

Created:
5 years, 7 months ago by jbroman
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Reland "Add UMA stats for record and raster time." These should provide a basic smoke test for real-world regressions from Slimming Paint phase 1. BUG=471873, 486214 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7b5b0557e0a757e040f8769857e7d78c6f0ed8c5 Cr-Commit-Position: refs/heads/master@{#331737}

Patch Set 1 : previously landed patch #

Patch Set 2 : explicit isnan check #

Patch Set 3 : comment #

Patch Set 4 : merge with master (conflicts with cc/resources move) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -0 lines) Patch
M cc/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/base/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A cc/base/histograms.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
A cc/base/histograms.cc View 1 2 1 chunk +50 lines, -0 lines 1 comment Download
A cc/base/histograms_unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/display_list_recording_source.cc View 1 2 3 4 chunks +13 lines, -0 lines 0 comments Download
M cc/playback/picture_pile.cc View 1 2 3 4 chunks +15 lines, -0 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
jbroman
WDYT? I had to revert the previous patch because somehow this is evaluating to NaN ...
5 years, 7 months ago (2015-05-14 03:50:05 UTC) #4
jbroman
On 2015/05/14 03:50:05, jbroman wrote: > WDYT? I had to revert the previous patch because ...
5 years, 7 months ago (2015-05-26 15:14:40 UTC) #5
jbroman
On 2015/05/26 15:14:40, jbroman wrote: > On 2015/05/14 03:50:05, jbroman wrote: > > WDYT? I ...
5 years, 7 months ago (2015-05-27 18:38:04 UTC) #6
enne (OOO)
lgtm Maybe put a comment by the nan that it's not clear why this is ...
5 years, 7 months ago (2015-05-27 18:56:11 UTC) #7
jbroman
On 2015/05/27 18:56:11, enne wrote: > lgtm > > Maybe put a comment by the ...
5 years, 7 months ago (2015-05-27 19:00:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139743004/80001
5 years, 7 months ago (2015-05-27 19:04:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/56734) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-27 19:11:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139743004/100001
5 years, 7 months ago (2015-05-27 19:19:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/66284)
5 years, 7 months ago (2015-05-27 19:29:28 UTC) #18
jbroman
isherman: Mind stamping for histograms? These histograms haven't changed substantially since originally landed (https://codereview.chromium.org/1075523002).
5 years, 7 months ago (2015-05-27 19:32:58 UTC) #20
jamesr
https://codereview.chromium.org/1139743004/diff/100001/cc/base/histograms.cc File cc/base/histograms.cc (right): https://codereview.chromium.org/1139743004/diff/100001/cc/base/histograms.cc#newcode42 cc/base/histograms.cc:42: // saturated_cast. http://crbug.com/486214 FYI in the past we've gotten ...
5 years, 7 months ago (2015-05-27 19:34:19 UTC) #22
Ilya Sherman
histograms lgtm
5 years, 7 months ago (2015-05-27 20:56:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139743004/100001
5 years, 7 months ago (2015-05-28 03:24:03 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 7 months ago (2015-05-28 03:37:10 UTC) #26
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 03:37:57 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7b5b0557e0a757e040f8769857e7d78c6f0ed8c5
Cr-Commit-Position: refs/heads/master@{#331737}

Powered by Google App Engine
This is Rietveld 408576698