Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1139733002: Add a bailout id just before every variable load in fullcode. (Closed)

Created:
5 years, 7 months ago by titzer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a bailout id just before every variable load in fullcode. R=jarin@chromium.org BUG= Committed: https://crrev.com/694890790d7c96df5310074366e243b337568adc Cr-Commit-Position: refs/heads/master@{#28344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 7 months ago (2015-05-11 14:19:53 UTC) #1
Jarin
lgtm (assuming that a CL using the new bailout id is coming soon).
5 years, 7 months ago (2015-05-11 14:47:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139733002/1
5 years, 7 months ago (2015-05-11 15:54:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 15:56:13 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 15:56:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/694890790d7c96df5310074366e243b337568adc
Cr-Commit-Position: refs/heads/master@{#28344}

Powered by Google App Engine
This is Rietveld 408576698