ipc: remove IPC_USES_READWRITE

ipc: remove IPC_USES_READWRITE

The Linux sandbox performance implications that made using
recvmsg()/sendmsg() slower than read()/write() have not applied for a
long time, since we switched from seccomp (v1) to seccomp-bpf.

Committed: https://crrev.com/ab00835c677f21e0f6a6deb89b36f07917f2b907
Cr-Commit-Position: refs/heads/master@{#330414}

[mdempsky, 2015-05-15 23:58:48]

mdempsky@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2015-05-16 01:35:25]

Thanks for the cleanup!

lgtm

[mdempsky, 2015-05-16 01:55:27]

mdempsky@chromium.org changed reviewers:
+ tsepez@chromium.org

[mdempsky, 2015-05-16 01:55:28]

+tsepez for ipc OWNERS

[hidehiko, 2015-05-18 04:54:04]

hidehiko@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hidehiko, 2015-05-18 04:54:05]

Thank you for quick work!
LGTM.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:322: 
nit: unnecessary empty line?

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:443: 
nit: unnecessary empty line?

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:448: {
nit: you do not need this brace pair.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:765: {
nit, you do not need this brace pair.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:815: error = "Message needs unreceived descriptors";
nit: indent?

[Tom Sepez, 2015-05-18 15:50:58]

lgtm

[mdempsky, 2015-05-18 17:58:37]

hidehiko: Good call, thanks.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.cc
File ipc/ipc_channel_posix.cc (right):

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:322: 
On 2015/05/18 04:54:05, hidehiko wrote:
> nit: unnecessary empty line?

Done.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:443: 
On 2015/05/18 04:54:05, hidehiko wrote:
> nit: unnecessary empty line?

Done.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:448: {
On 2015/05/18 04:54:05, hidehiko wrote:
> nit: you do not need this brace pair.

Done.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:765: {
On 2015/05/18 04:54:05, hidehiko wrote:
> nit, you do not need this brace pair.

Done.

https://codereview.chromium.org/1139703005/diff/20001/ipc/ipc_channel_posix.c...
ipc/ipc_channel_posix.cc:815: error = "Message needs unreceived descriptors";
On 2015/05/18 04:54:05, hidehiko wrote:
> nit: indent?

Done.

[mdempsky, 2015-05-18 17:58:49]

The CQ bit was checked by mdempsky@chromium.org

[mdempsky, 2015-05-18 17:58:50]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
hidehiko@chromium.org, jln@chromium.org
Link to the patchset: https://codereview.chromium.org/1139703005/#ps40001
(title: "Nits from hidehiko@")

[commit-bot: I haz the power, 2015-05-18 18:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139703005/40001

[commit-bot: I haz the power, 2015-05-18 20:57:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-18 22:43:00]

Patchset 3 (id:??) landed as
https://crrev.com/ab00835c677f21e0f6a6deb89b36f07917f2b907
Cr-Commit-Position: refs/heads/master@{#330414}