Fixed bug 129

test/cctest/test-regexp.cc

Index: test/cctest/test-regexp.cc
diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc
index 549887b9572f892d9fabb2239d454f75f91d17ff..df1ddad82c429ef52457f647955cf0a72775cb7a 100644
--- a/test/cctest/test-regexp.cc
+++ b/test/cctest/test-regexp.cc
@@ -274,7 +274,7 @@ TEST(Errors) {
   ExpectError("[a-\\w]", kIllegalCharacterClass);
   const char* kEndControl = "\\c at end of pattern";
   ExpectError("\\c", kEndControl);
-  static char* kNothingToRepeat = "Nothing to repeat";
+  static const char* kNothingToRepeat = "Nothing to repeat";

[Lasse Reichstein, 2008/11/24 14:08:57]

Why static? The rest of the const char* variables aren't.

   ExpectError("*", kNothingToRepeat);
   ExpectError("?", kNothingToRepeat);
   ExpectError("+", kNothingToRepeat);
@@ -780,14 +780,10 @@ TEST(LatinCanonicalize) {
     CHECK_EQ(upper, uncanon[0]);
     CHECK_EQ(lower, uncanon[1]);
   }
-  for (uc32 c = 128; c < (1 << 21); c++) {
-    // These exceptions are caused by a known bug in the implementation.
-    if (c != 0x026B && c != 0x027D)
-      CHECK_GE(canonicalize(c), 128);
-  }
+  for (uc32 c = 128; c < (1 << 21); c++)
+    CHECK_GE(canonicalize(c), 128);
   unibrow::Mapping<unibrow::ToUppercase> to_upper;
   for (uc32 c = 0; c < (1 << 21); c++) {
-    if (c == 0x026B || c == 0x027D) continue;
     unibrow::uchar upper[unibrow::ToUppercase::kMaxWidth];
     int length = to_upper.get(c, '\0', upper);
     if (length == 0) {
@@ -797,8 +793,6 @@ TEST(LatinCanonicalize) {
     uc32 u = upper[0];
     if (length > 1 || (c >= 128 && u < 128))
       u = c;
-    if (u != canonicalize(c))
-      printf("%x\n", c);
     CHECK_EQ(u, canonicalize(c));
   }
 }