Fixed bug 129

test/cctest/test-regexp.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 256 matching lines @@
   ExpectError("(foo", kUnterminatedGroup);
   const char* kInvalidGroup = "Invalid group";
   ExpectError("(?", kInvalidGroup);
   const char* kUnterminatedCharacterClass = "Unterminated character class";
   ExpectError("[", kUnterminatedCharacterClass);
   ExpectError("[a-", kUnterminatedCharacterClass);
   const char* kIllegalCharacterClass = "Illegal character class";
   ExpectError("[a-\\w]", kIllegalCharacterClass);
   const char* kEndControl = "\\c at end of pattern";
   ExpectError("\\c", kEndControl);
-  static char* kNothingToRepeat = "Nothing to repeat";
+  static const char* kNothingToRepeat = "Nothing to repeat";

[Lasse Reichstein, 2008/11/24 14:08:57]

Why static? The rest of the const char* variables aren't.

   ExpectError("*", kNothingToRepeat);
   ExpectError("?", kNothingToRepeat);
   ExpectError("+", kNothingToRepeat);
   ExpectError("{1}", kNothingToRepeat);
   ExpectError("{1,2}", kNothingToRepeat);
   ExpectError("{1,}", kNothingToRepeat);
 }
 
 
 static bool IsDigit(uc16 c) {
@@ skipping 485 matching lines @@
   unibrow::Mapping<unibrow::Ecma262UnCanonicalize> un_canonicalize;
   for (char lower = 'a'; lower <= 'z'; lower++) {
     char upper = lower + ('A' - 'a');
     CHECK_EQ(canonicalize(lower), canonicalize(upper));
     unibrow::uchar uncanon[unibrow::Ecma262UnCanonicalize::kMaxWidth];
     int length = un_canonicalize.get(lower, '\0', uncanon);
     CHECK_EQ(2, length);
     CHECK_EQ(upper, uncanon[0]);
     CHECK_EQ(lower, uncanon[1]);
   }
-  for (uc32 c = 128; c < (1 << 21); c++) {
-    // These exceptions are caused by a known bug in the implementation.
-    if (c != 0x026B && c != 0x027D)
-      CHECK_GE(canonicalize(c), 128);
-  }
+  for (uc32 c = 128; c < (1 << 21); c++)
+    CHECK_GE(canonicalize(c), 128);
   unibrow::Mapping<unibrow::ToUppercase> to_upper;
   for (uc32 c = 0; c < (1 << 21); c++) {
-    if (c == 0x026B || c == 0x027D) continue;
     unibrow::uchar upper[unibrow::ToUppercase::kMaxWidth];
     int length = to_upper.get(c, '\0', upper);
     if (length == 0) {
       length = 1;
       upper[0] = c;
     }
     uc32 u = upper[0];
     if (length > 1 || (c >= 128 && u < 128))
       u = c;
-    if (u != canonicalize(c))
-      printf("%x\n", c);
     CHECK_EQ(u, canonicalize(c));
   }
 }
 
 
 TEST(SimplePropagation) {
   v8::HandleScope scope;
   ZoneScope zone_scope(DELETE_ON_EXIT);
   RegExpNode* node = Compile("(a|^b|c)");
   CHECK(node->info()->determine_start);
@@ skipping 106 matching lines @@
   // whole block at a time.
   TestSimpleRangeCaseIndependence(CharacterRange('A', 'k'),
                                   CharacterRange('a', 'z'));
 }
 
 
 TEST(Graph) {
   V8::Initialize(NULL);
   Execute("(x)?\\1y", "", true);
 }