Issue 11397: Fixed bug 129

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11397: Fixed bug 129 (Closed)

Created:
12 years, 1 month ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Visibility:
Public.

Description

Fixed bug 129 by making the unicode tables wider and moving the various control bits higher up in the words. There are still issues with uncanonicalize and canonicalization ranges but I will address them in a separate changelist.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -73 lines)			Patch
M	src/jsregexp.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/unicode.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/unicode.cc	View	22 chunks	+67 lines, -60 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	3 chunks	+3 lines, -9 lines	1 comment	Download
A	test/mjsunit/regress/regress-149.js	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years, 1 month ago (2008-11-24 14:08:57 UTC) #2

LGTM

http://codereview.chromium.org/11397/diff/1/5
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/11397/diff/1/5#newcode277
Line 277: static const char* kNothingToRepeat = "Nothing to repeat";
Why static? The rest of the const char* variables aren't.

Expand Messages | Collapse Messages