Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1139673005: fix temps that have the same name to have different Elements (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm, Brian Wilkerson
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix temps that have the same name to have different Elements this was happening because we picked up an == operator from analyzer's Element also adds an assert, because I took way too much time figuring out what the heck was happening there :) R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2ab8611a81b934e908ee226ce079811c196b2aa6

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 4 chunks +12 lines, -4 lines 0 comments Download
M lib/src/codegen/js_names.dart View 1 chunk +4 lines, -1 line 0 comments Download
M test/codegen/expect/try_catch.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
https://codereview.chromium.org/1139673005/diff/1/test/codegen/expect/try_catch.js File test/codegen/expect/try_catch.js (right): https://codereview.chromium.org/1139673005/diff/1/test/codegen/expect/try_catch.js#newcode56 test/codegen/expect/try_catch.js:56: } catch (e) { the name here should've been ...
5 years, 7 months ago (2015-05-11 23:22:01 UTC) #2
vsm
[+brian for the q on LocalVariableElementImpl] lgtm https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen.dart#newcode2627 lib/src/codegen/js_codegen.dart:2627: operator ==(Object ...
5 years, 7 months ago (2015-05-11 23:30:34 UTC) #4
Jennifer Messerly
fyi, added hashCode ... totally forgot the first time https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen.dart#newcode2625 lib/src/codegen/js_codegen.dart:2625: ...
5 years, 7 months ago (2015-05-11 23:36:49 UTC) #5
Jennifer Messerly
5 years, 7 months ago (2015-05-11 23:40:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2ab8611a81b934e908ee226ce079811c196b2aa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698