fix temps that have the same name to have different Elements

fix temps that have the same name to have different Elements
this was happening because we picked up an == operator from analyzer's Element

also adds an assert, because I took way too much time figuring out what the heck was happening there :)

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/2ab8611a81b934e908ee226ce079811c196b2aa6

[Jennifer Messerly, 2015-05-11 23:21:10]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[Jennifer Messerly, 2015-05-11 23:22:01]

https://codereview.chromium.org/1139673005/diff/1/test/codegen/expect/try_cat...
File test/codegen/expect/try_catch.js (right):

https://codereview.chromium.org/1139673005/diff/1/test/codegen/expect/try_cat...
test/codegen/expect/try_catch.js:56: } catch (e) {
the name here should've been a clue ... why `e$` when no other `e` is in this
scope?

[vsm, 2015-05-11 23:30:33]

vsm@google.com changed reviewers:
+ brianwilkerson@google.com

[vsm, 2015-05-11 23:30:34]

[+brian for the q on LocalVariableElementImpl]

lgtm

https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2627: operator ==(Object other) =>
identical(this, other);
Should LocalVariableElementImpl just do the same thing?

[Jennifer Messerly, 2015-05-11 23:36:49]

fyi, added hashCode ... totally forgot the first time

https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2625:
TemporaryVariableElement.forNode(Identifier name) : super.forNode(name);
just realized I should add hashCode too

https://codereview.chromium.org/1139673005/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2627: operator ==(Object other) =>
identical(this, other);
On 2015/05/11 23:30:34, vsm wrote:
> Should LocalVariableElementImpl just do the same thing?

maybe ... it definitely surprised me that name/offset was enough for them to be
==, especially when the offset is invalid.

[Jennifer Messerly, 2015-05-11 23:40:22]

Committed patchset #2 (id:20001) manually as
2ab8611a81b934e908ee226ce079811c196b2aa6 (presubmit successful).