mojo/services/network/network_service_delegate.cc - Issue 1139673003: Make Mandoline shut down cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/network/network_service_delegate.cc

Issue 1139673003: Make Mandoline shut down cleanly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix crash in surfaces if surfaceimpl outlives the app, and a double delete in browser Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/network/network_service_delegate.cc

diff --git a/mojo/services/network/network_service_delegate.cc b/mojo/services/network/network_service_delegate.cc

index d608b33dd8a1884d9c29ce28cdd2a5b967ef8337..2484e6564b8dd8a5d95bc770f4fde4ef93284832 100644

--- a/mojo/services/network/network_service_delegate.cc

+++ b/mojo/services/network/network_service_delegate.cc

@@ -40,5 +40,9 @@ void NetworkServiceDelegate::Create(

mojo::ApplicationConnection* connection,

mojo::InterfaceRequest<mojo::NetworkService> request) {

mojo::BindToRequest(

- new mojo::NetworkServiceImpl(connection, context_.get()), &request);

+ new mojo::NetworkServiceImpl(

+ connection,

+ context_.get(),

+ app_lifetime_helper.CreateServiceRefCount()),

+ &request);

}