Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1139643008: [BackgroundSync] Fix lifetime issues with callbacks pointer in CallbackThreadAdapter (Closed)

Created:
5 years, 7 months ago by iclelland
Modified:
5 years, 7 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync] Fix lifetime issues with callbacks pointer in CallbackThreadAdapter This correctly assigns ownership of the callbacks_ object to the closure created by base::Bind when posting the success/error handling task to the correct thread. BUG=488452 Committed: https://crrev.com/80341c95839b9eda74398825d63c91f22a5a3eec Cr-Commit-Position: refs/heads/master@{#330094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/child/background_sync/background_sync_provider_thread_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
iclelland
5 years, 7 months ago (2015-05-15 12:56:23 UTC) #2
jkarlin
lgtm
5 years, 7 months ago (2015-05-15 13:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139643008/1
5 years, 7 months ago (2015-05-15 13:03:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 14:40:23 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 14:41:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80341c95839b9eda74398825d63c91f22a5a3eec
Cr-Commit-Position: refs/heads/master@{#330094}

Powered by Google App Engine
This is Rietveld 408576698