Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java

Issue 1139643006: Rename chrome/android/javatests to javatests_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
deleted file mode 100644
index c8b1d82c9bb61ad31a153fc13772aba47a4d3523..0000000000000000000000000000000000000000
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/ChromeDownloadDelegateTest.java
+++ /dev/null
@@ -1,96 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.download;
-
-import android.content.Context;
-import android.test.InstrumentationTestCase;
-import android.test.suitebuilder.annotation.SmallTest;
-
-import org.chromium.base.test.util.Feature;
-import org.chromium.content.browser.DownloadInfo;
-
-/**
- * Tests for ChromeDownloadDelegate class.
- */
-public class ChromeDownloadDelegateTest extends InstrumentationTestCase {
-
- /**
- * Mock class for test.
- */
- static class MockChromeDownloadDelegate extends ChromeDownloadDelegate {
- public MockChromeDownloadDelegate(Context context) {
- super(context, null, null);
- }
-
- @Override
- protected void onDownloadStartNoStream(DownloadInfo downloadInfo) {
- }
- }
-
- /**
- * Test to make sure {@link ChromeDownloadDelegate#fileName} returns the
- * right file for different URLs and MIME types.
- */
- @SmallTest
- @Feature({"Download"})
- public void testFileName() {
- String testUrl = "http://server.com/file.pdf";
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf", ""));
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "", ""));
-
- // .php is an unknown MIME format extension.
- // This used to generate file.php even when the MIME type was set.
- // http://code.google.com/p/chromium/issues/detail?id=134396
- testUrl = "http://server.com/file.php";
-
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf", ""));
- assertEquals("file.php", ChromeDownloadDelegate.fileName(testUrl, "", ""));
-
- // .xml is a known MIME format extension.
- testUrl = "http://server.com/file.xml";
- assertEquals("file.xml", ChromeDownloadDelegate.fileName(testUrl, "", ""));
-
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf", ""));
-
- // If the file's extension and HTTP header's MIME type are the same, use
- // the former to derive the final extension.
- // https://code.google.com/p/chromium/issues/detail?id=170852
- testUrl = "http://server.com/file.mp3";
- assertEquals("file.mp3", ChromeDownloadDelegate.fileName(testUrl, "audio/mpeg", ""));
-
- testUrl = "http://server.com/";
- assertEquals("downloadfile.bin", ChromeDownloadDelegate.fileName(testUrl, "", ""));
- assertEquals("downloadfile.pdf",
- ChromeDownloadDelegate.fileName(testUrl, "application/pdf", ""));
-
- // Fails to match the filename pattern from header; uses one from url.
- // Note that header itself is a valid one.
- testUrl = "http://server.com/file.pdf";
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf",
- "attachment; name=\"foo\"; filename=\"bar\""));
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf",
- "attachment; filename=\"bar\"; name=\"foo\""));
- assertEquals("file.pdf", ChromeDownloadDelegate.fileName(testUrl, "application/pdf",
- "attachment; filename=\"bar\"; filename*=utf-8''baz"));
- }
-
- /**
- * Test to make sure {@link ChromeDownloadDelegate#shouldInterceptContextMenuDownload}
- * returns true only for ".dd" or ".dm" extensions with http/https scheme.
- */
- @SmallTest
- @Feature({"Download"})
- public void testShouldInterceptContextMenuDownload() {
- ChromeDownloadDelegate delegate =
- new MockChromeDownloadDelegate(getInstrumentation().getTargetContext());
- assertFalse(delegate.shouldInterceptContextMenuDownload("file://test/test.html"));
- assertFalse(delegate.shouldInterceptContextMenuDownload("http://test/test.html"));
- assertFalse(delegate.shouldInterceptContextMenuDownload("ftp://test/test.dm"));
- assertFalse(delegate.shouldInterceptContextMenuDownload("data://test.dd"));
- assertFalse(delegate.shouldInterceptContextMenuDownload("http://test.dd"));
- assertTrue(delegate.shouldInterceptContextMenuDownload("http://test/test.dd"));
- assertTrue(delegate.shouldInterceptContextMenuDownload("https://test/test.dm"));
- }
-}

Powered by Google App Engine
This is Rietveld 408576698