chrome/chrome_browser_extensions.gypi - Issue 1139643005: Extract ErrorConsole from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_extensions.gypi

Issue 1139643005: Extract ErrorConsole from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use ErrorConsole::Get, update year for copyright lines Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser_extensions.gypi

diff --git a/chrome/chrome_browser_extensions.gypi b/chrome/chrome_browser_extensions.gypi

index 4ef251b30c7b0236f978c32a2d168d088250d65a..ad3feb26f5c2e2948e8a5c5f5b3fe2b17195a379 100644

--- a/chrome/chrome_browser_extensions.gypi

+++ b/chrome/chrome_browser_extensions.gypi

@@ -568,6 +568,8 @@

'browser/extensions/display_info_provider_win.h',

'browser/extensions/error_console/error_console.cc',

'browser/extensions/error_console/error_console.h',

+ 'browser/extensions/error_console/error_console_factory.cc',

+ 'browser/extensions/error_console/error_console_factory.h',

'browser/extensions/event_router_forwarder.cc',

'browser/extensions/event_router_forwarder.h',

'browser/extensions/extension_action.cc',