chrome/browser/extensions/error_console/error_console.h - Issue 1139643005: Extract ErrorConsole from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console.h

Issue 1139643005: Extract ErrorConsole from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use ErrorConsole::Get, update year for copyright lines Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/error_console/error_console.h

diff --git a/chrome/browser/extensions/error_console/error_console.h b/chrome/browser/extensions/error_console/error_console.h

index 006c31f4c37c66326b6da5f1f1025b3567d63710..fe5de34503fc1a74e63ad3eb199566bb022fdb52 100644

--- a/chrome/browser/extensions/error_console/error_console.h

+++ b/chrome/browser/extensions/error_console/error_console.h

@@ -10,6 +10,7 @@

#include "base/prefs/pref_change_registrar.h"

#include "base/scoped_observer.h"

#include "base/threading/thread_checker.h"

+#include "components/keyed_service/core/keyed_service.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "extensions/browser/error_map.h"

@@ -36,7 +37,8 @@ class ExtensionRegistry;

// errors can be viewed at chrome://extensions in developer mode.

// This class is owned by ExtensionSystem, making it, in effect, a

// BrowserContext-keyed service.

-class ErrorConsole : public content::NotificationObserver,

+class ErrorConsole : public KeyedService,

+ public content::NotificationObserver,

public ExtensionRegistryObserver {

public:

class Observer {