chrome/browser/extensions/chrome_extension_web_contents_observer.cc - Issue 1139643005: Extract ErrorConsole from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_web_contents_observer.cc

Issue 1139643005: Extract ErrorConsole from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/error_console/error_console.h » ('j') | chrome/browser/extensions/error_console/error_console_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_web_contents_observer.cc

diff --git a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

index a407d627d8cb0cfa49bb6c91b9fbe0ec6bd29129..964e2d1be1d37c7965979e7849ce4cffcbe1f2fc 100644

--- a/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

+++ b/chrome/browser/extensions/chrome_extension_web_contents_observer.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"

#include "chrome/browser/extensions/error_console/error_console.h"

+#include "chrome/browser/extensions/error_console/error_console_factory.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/common/extensions/chrome_extension_messages.h"

#include "content/public/browser/browser_context.h"

@@ -60,7 +61,7 @@ void ChromeExtensionWebContentsObserver::OnDetailedConsoleMessageAdded(

if (extension_id.empty())

extension_id = GURL(source).host();

- ExtensionSystem::Get(browser_context())->error_console()->ReportError(

+ ErrorConsoleFactory::GetForBrowserContext(browser_context())->ReportError(

Reilly Grant (use Gerrit) 2015/05/12 17:58:52 Use ErrorConsole::Get instead of including error_c

juncai 2015/05/12 19:01:01 Done.

scoped_ptr<ExtensionError>(

new RuntimeError(extension_id,

browser_context()->IsOffTheRecord(),

« no previous file with comments | « no previous file | chrome/browser/extensions/error_console/error_console.h » ('j') | chrome/browser/extensions/error_console/error_console_factory.h » ('J')