Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 113963003: added scss files (Closed)

Created:
7 years ago by Renato Mangini (chromium)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

imported scss files from Github prototype project; BUG=330235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244328

Patch Set 1 #

Patch Set 2 : Trying to circunvent problems with rietveld patch #

Patch Set 3 : rebased to avoid issue with patch #

Patch Set 4 : Removed config.rb #

Patch Set 5 : added config.rb back and rebased to trunk #

Patch Set 6 : Fixed license error on generated site.css ; rebased to trunk #

Patch Set 7 : removed config.rb, because of issues in svn handling of the filetype #

Patch Set 8 : moved site.css to out subdirectory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2721 lines, -2724 lines) Patch
A chrome/common/extensions/docs/.gitignore View 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/README View 1 2 3 4 5 6 7 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/render_servlet_test.py View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/static/css/out/site.css View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/css/site.css View 1 2 3 4 5 6 7 1 chunk +0 lines, -2721 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_article.scss View 1 2 1 chunk +182 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_grid.scss View 2 1 chunk +94 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_homepage.scss View 2 1 chunk +96 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_html.scss View 2 1 chunk +594 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_layout.scss View 2 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_mixins.scss View 2 1 chunk +145 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_navbar.scss View 2 1 chunk +369 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_normalize.scss View 1 2 1 chunk +638 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_pillar.scss View 2 1 chunk +165 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_typography.scss View 2 1 chunk +229 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/_vars.scss View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/static/sass/site.scss View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/private/cc.html View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/site.html View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (0 generated)
Renato Mangini (chromium)
Ready for review. Observe that I've added all scss files from Github, so we can ...
7 years ago (2013-12-20 13:16:28 UTC) #1
not at google - send to devlin
Is this urgent? Kun will soon be submitting native scss support into the docserver which ...
7 years ago (2013-12-20 23:30:51 UTC) #2
Renato Mangini (chromium)
On 2013/12/20 23:30:51, kalman wrote: > Is this urgent? Kun will soon be submitting native ...
6 years, 12 months ago (2013-12-23 12:41:27 UTC) #3
hukun_google.com
I am ready to submit the CL. Maybe it would be committed in one or ...
6 years, 12 months ago (2013-12-24 02:03:57 UTC) #4
Renato Mangini (chromium)
I can't commit most of the other CLs until this one (or hukun's) lands, because ...
6 years, 12 months ago (2013-12-27 13:29:38 UTC) #5
not at google - send to devlin
So if you want to commit this now that's fine but I'd want to roll ...
6 years, 11 months ago (2013-12-27 22:51:03 UTC) #6
Renato Mangini (chromium)
On 2013/12/27 22:51:03, kalman wrote: > So if you want to commit this now that's ...
6 years, 11 months ago (2013-12-30 12:47:42 UTC) #7
not at google - send to devlin
Yeah that's what Kun's patch will do, and oops I read those files as being ...
6 years, 11 months ago (2013-12-31 00:10:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/70002
6 years, 11 months ago (2014-01-03 13:42:29 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43151
6 years, 11 months ago (2014-01-03 13:56:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/340001
6 years, 11 months ago (2014-01-03 14:44:40 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/config.rb: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 11 months ago (2014-01-03 14:44:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/350005
6 years, 11 months ago (2014-01-03 14:56:19 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/docs/config.rb: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 11 months ago (2014-01-03 14:56:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/420001
6 years, 11 months ago (2014-01-03 15:10:45 UTC) #15
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43170
6 years, 11 months ago (2014-01-03 15:37:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/530001
6 years, 11 months ago (2014-01-03 16:17:37 UTC) #17
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43178
6 years, 11 months ago (2014-01-03 16:39:57 UTC) #18
hukun_google.com
Sorry. I did not notice this email until today. I will upload scss relative CL ...
6 years, 11 months ago (2014-01-06 07:36:15 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/690001
6 years, 11 months ago (2014-01-09 21:40:40 UTC) #20
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44165
6 years, 11 months ago (2014-01-09 22:05:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/820001
6 years, 11 months ago (2014-01-10 00:27:02 UTC) #22
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44226
6 years, 11 months ago (2014-01-10 01:05:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mangini@chromium.org/113963003/930001
6 years, 11 months ago (2014-01-11 00:20:17 UTC) #24
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 03:10:36 UTC) #25
Message was sent while issue was closed.
Change committed as 244328

Powered by Google App Engine
This is Rietveld 408576698