Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

Issue 1139623003: Removes the redundant IMB::OnFocus call in DNWA::HandleNativeFocus(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
index cfd6d1065731bdd5c52bb2c3af7295b795b9a198..e4d4069569d73169faac7b3a7f735fac9d063f0f 100644
--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
@@ -820,16 +820,10 @@ void DesktopWindowTreeHostWin::HandleFrameChanged() {
void DesktopWindowTreeHostWin::HandleNativeFocus(HWND last_focused_window) {
// TODO(beng): inform the native_widget_delegate_.
sky 2015/05/22 17:29:02 I think it's worth a comment here as to why you do
Shu Chen 2015/05/25 01:14:25 Thanks for your comment. My later cl soon to refac
- InputMethod* input_method = GetInputMethod();
- if (input_method)
- input_method->OnFocus();
}
void DesktopWindowTreeHostWin::HandleNativeBlur(HWND focused_window) {
// TODO(beng): inform the native_widget_delegate_.
- InputMethod* input_method = GetInputMethod();
- if (input_method)
- input_method->OnBlur();
}
sadrul 2015/05/16 02:24:25 The X11 version seems to still do this (e.g. Deskt
Shu Chen 2015/05/20 06:30:52 Let's limit the scope of this change in Windows pl
bool DesktopWindowTreeHostWin::HandleMouseEvent(const ui::MouseEvent& event) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698