cc/scheduler/scheduler_state_machine.h - Issue 1139613003: cc: Avoid deadlock with the UI thread and NPAPI in more cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/scheduler_state_machine.h

Issue 1139613003: cc: Avoid deadlock with the UI thread and NPAPI in more cases (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Sunny's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/scheduler/scheduler_state_machine.h

diff --git a/cc/scheduler/scheduler_state_machine.h b/cc/scheduler/scheduler_state_machine.h

index cf29ca9b6a53ec89a43c1b20e905e9c4792dff8f..238c08c42d166c47acd80c4a682fd225cbf6d033 100644

--- a/cc/scheduler/scheduler_state_machine.h

+++ b/cc/scheduler/scheduler_state_machine.h

@@ -268,6 +268,9 @@ class CC_EXPORT SchedulerStateMachine {

// True if we need to force activations to make forward progress.

bool PendingActivationsShouldBeForced() const;

+ // TODO(brianderson): Remove this once NPAPI support is removed.

+ bool SendingBeginMainFrameMightCauseDeadlock() const;

bool ShouldAnimate() const;

bool ShouldBeginOutputSurfaceCreation() const;

bool ShouldDraw() const;

« no previous file with comments | « cc/scheduler/scheduler_settings.cc ('k') | cc/scheduler/scheduler_state_machine.cc » ('j') | no next file with comments »