Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1139603006: Fix order in .gypi files (Closed)

Created:
5 years, 7 months ago by vabr (Chromium)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix order in .gypi files The tools/git/move_source_file.py tool relies on the alphabetic ordering, and will mess up changes if the gypi files are not initially sorted. BUG=486739 Committed: https://crrev.com/849974f5745e000ce1edbd9ac7415e56f8fb4659 Cr-Commit-Position: refs/heads/master@{#330552}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/chrome_browser.gypi View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vabr (Chromium)
Hi Mike, Please have a look. This is an n-th level yak-shaving. :) Cheers, Vaclav
5 years, 7 months ago (2015-05-19 16:59:37 UTC) #2
Mike West
ABCDEFGHIJK... LGTM.
5 years, 7 months ago (2015-05-19 17:01:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139603006/1
5 years, 7 months ago (2015-05-19 17:06:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 17:50:50 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:51:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/849974f5745e000ce1edbd9ac7415e56f8fb4659
Cr-Commit-Position: refs/heads/master@{#330552}

Powered by Google App Engine
This is Rietveld 408576698