[destructuring] Implement BindingArrayPattern

[destructuring] Implement BindingArrayPattern

(everything except Spread is implemeneted)

R=arv@chromium.org,rossberg@chromium.org,wingo@igalia.com
BUG=v8:811
LOG=N

Committed: https://crrev.com/a38e3a4518219f41d57fc3c7dc5ae649599d7739
Cr-Commit-Position: refs/heads/master@{#28500}

[Dmitry Lomov (no reviews), 2015-05-19 16:54:02]

PTAL

[Dmitry Lomov (no reviews), 2015-05-19 17:01:05]

dslomov@chromium.org changed reviewers:
+ rossberg@chromium.org
- rossberg@chromiumn.org

[Dmitry Lomov (no reviews), 2015-05-19 17:01:21]

The CQ bit was checked by dslomov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-19 17:01:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139603005/1

[arv (Not doing code reviews), 2015-05-19 17:03:48]

LGTM

https://codereview.chromium.org/1139603005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1139603005/diff/1/src/parser.cc#newcode3095
src/parser.cc:3095:
Runtime::FunctionForId(Runtime::kThrowIteratorResultNotAnObject),
Can you use a NewTypeError Expression instead of adding this runtime function?

Since we already have it I think it is OK but we should probably remove some of
these later...

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
File test/mjsunit/harmony/destructuring.js (right):

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
test/mjsunit/harmony/destructuring.js:394: var [a,b,c] = [1,2,3];
ws

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
test/mjsunit/harmony/destructuring.js:535: 
Can you add some recursive tests too?

[commit-bot: I haz the power, 2015-05-19 17:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 17:31:13]

Dry run: This issue passed the CQ dry run.

[rossberg, 2015-05-20 06:55:09]

LGTM, although for this part I wonder whether straightforward desugaring really
is the way forward. We probably want to special-case arrays, for example, and
recovering that case from the desugaring later will be pretty tedious.

Anyway, not an issue right now, so LGTM.

[Dmitry Lomov (no reviews), 2015-05-20 07:42:43]

Landing

https://codereview.chromium.org/1139603005/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1139603005/diff/1/src/parser.cc#newcode3095
src/parser.cc:3095:
Runtime::FunctionForId(Runtime::kThrowIteratorResultNotAnObject),
On 2015/05/19 17:03:48, arv wrote:
> Can you use a NewTypeError Expression instead of adding this runtime function?
> 
> Since we already have it I think it is OK but we should probably remove some
of
> these later...

I tried that, need to change NewThrowTypeError to accept arbitrary expressions
instead of just literals for arg so too much unrelated change in this CL. Will
do in the follow-up.

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
File test/mjsunit/harmony/destructuring.js (right):

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
test/mjsunit/harmony/destructuring.js:394: var [a,b,c] = [1,2,3];
On 2015/05/19 17:03:48, arv wrote:
> ws

Done.

https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destru...
test/mjsunit/harmony/destructuring.js:535: 
On 2015/05/19 17:03:48, arv wrote:
> Can you add some recursive tests too?

Done.

[Dmitry Lomov (no reviews), 2015-05-20 07:42:48]

The CQ bit was checked by dslomov@chromium.org

[Dmitry Lomov (no reviews), 2015-05-20 07:42:48]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/1139603005/#ps20001
(title: "Rebased + feedback")

[commit-bot: I haz the power, 2015-05-20 07:42:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139603005/20001

[commit-bot: I haz the power, 2015-05-20 08:08:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 08:08:52]

Patchset 2 (id:??) landed as
https://crrev.com/a38e3a4518219f41d57fc3c7dc5ae649599d7739
Cr-Commit-Position: refs/heads/master@{#28500}