Issue 1139603003: Fix crash in echoPrivate.getUserConsent when there are no browser windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1139603003: Fix crash in echoPrivate.getUserConsent when there are no browser windows (Closed)

Created:
5 years, 7 months ago by tbarzic

Modified:
5 years, 7 months ago

Reviewers:
rkc

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash in echoPrivate.getUserConsent when there are no browser windows The method can be called from Files app, and crashes if there are no browser windows open. BUG=None Committed: https://crrev.com/99b460b7776d6a2ce7f32716a5f8501ae2b94868 Cr-Commit-Position: refs/heads/master@{#329746}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/extensions/echo_private_api.cc	View	1 2	3 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139603003/40001

5 years, 7 months ago (2015-05-13 22:19:55 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 00:03:41 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/99b460b7776d6a2ce7f32716a5f8501ae2b94868
Cr-Commit-Position: refs/heads/master@{#329746}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages