Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: remoting/webapp/base/js/typecheck.js

Issue 1139543002: [Chromoting] Show any startup errors in the LoadingWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/typecheck.js
diff --git a/remoting/webapp/base/js/typecheck.js b/remoting/webapp/base/js/typecheck.js
index 10e1959dd7b33fec2055708c5b0f5329eb0c5a03..17b16a6f5456e85cfb9a5967f967e5c8bacf88c8 100644
--- a/remoting/webapp/base/js/typecheck.js
+++ b/remoting/webapp/base/js/typecheck.js
@@ -19,17 +19,25 @@ var isArray = function(value) {
/**
* @param {*} value
+ * @param {boolean=} opt_allowUndefined True to accept undefined.
* @return {boolean}
*/
-var isBoolean = function(value) {
+var isBoolean = function(value, opt_allowUndefined) {
+ if (opt_allowUndefined && value === 'undefined') {
+ return true;
+ }
return typeof value == 'boolean';
};
/**
* @param {*} value
+ * @param {boolean=} opt_allowUndefined True to accept undefined.
* @return {boolean}
*/
-var isNumber = function(value) {
+var isNumber = function(value, opt_allowUndefined) {
+ if (opt_allowUndefined && value === 'undefined') {
+ return true;
+ }
return typeof value == 'number';
};
@@ -43,9 +51,13 @@ var isObject = function(value) {
/**
* @param {*} value
+ * @param {boolean=} opt_allowUndefined True to accept undefined.
* @return {boolean}
*/
-var isString = function(value) {
+var isString = function(value, opt_allowUndefined) {
+ if (opt_allowUndefined && value === 'undefined') {
+ return true;
+ }
return typeof value == 'string';
};
@@ -246,4 +258,4 @@ base.getJsonObjectFromString = function(jsonString) {
return base.assertObject(base.jsonParseSafe(jsonString));
};
-})();
+})();
« remoting/webapp/base/js/message_window.js ('K') | « remoting/webapp/base/js/message_window_helper.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698