[Chromoting] Show any startup errors in the LoadingWindow.

remoting/webapp/base/js/typecheck.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 (function() {
 'use strict';
 
 /**
  * @param {*} value
  * @return {boolean}
  */
 var isArray = function(value) {
   return Array.isArray(value);
 };
 
 /**
  * @param {*} value
+ * @param {boolean=} allowUndefined True to allow undefined as a valid boolean.

[Jamie, 2015/05/13 23:43:18]

Optional parameters should be prefixed with opt_

[garykac, 2015/05/15 01:29:36]

Done.

  * @return {boolean}
  */
-var isBoolean = function(value) {
+var isBoolean = function(value, allowUndefined) {
+  if (allowUndefined && typeof value === 'undefined') {

[Jamie, 2015/05/13 23:43:18]

No need for typeof here; "value === undefined" is equivalent and verifiable by
the compiler.

[garykac, 2015/05/15 01:29:36]

Done.

+    return true;
+  }
   return typeof value == 'boolean';
 };
 
 /**
  * @param {*} value
+ * @param {boolean=} allowUndefined True to allow undefined as a valid number.

[Jamie, 2015/05/13 23:43:18]

You haven't added allowUndefined to the parameter list, so I'm surprised this
compiles.

[garykac, 2015/05/15 01:29:36]

Fixed.

  * @return {boolean}
  */
 var isNumber = function(value) {
+  if (allowUndefined && typeof value === 'undefined') {
+    return true;
+  }
   return typeof value == 'number';
 };
 
 /**
  * @param {*} value
  * @return {boolean}
  */
 var isObject = function(value) {
   return value != null && typeof value == 'object' && !Array.isArray(value);
 };
 
 /**
  * @param {*} value
+ * @param {boolean=} allowUndefined True to allow undefined as a valid string.
  * @return {boolean}
  */
 var isString = function(value) {
+  if (allowUndefined && typeof value === 'undefined') {
+    return true;
+  }
   return typeof value == 'string';
 };
 
 /**
  * @param {*} value
  * @return {string}
  */
 var jsonTypeOf = function(value) {
   if (typeof value == 'object') {
     if (value === null) {
@@ skipping 180 matching lines @@
  * If the string cannot be parsed, or does not result in an object, then an
  * exception will be thrown.
  *
  * @param {string} jsonString The JSON string to parse.
  * @return {Object} The JSON object created from the |jsonString|.
  */
 base.getJsonObjectFromString = function(jsonString) {
   return base.assertObject(base.jsonParseSafe(jsonString));
 };
 
-})();
+})();