Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 1139533007: Use SetRawInfo in PersonalDataManagerAndroid::PopulateNativeProfileFromJava (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index d0ef526670601020f76f3132eeb01047213523f8..701438fae90c57b51a0cc0201f020c95ed7b15a7 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -76,60 +76,41 @@ void PopulateNativeProfileFromJava(
profile->set_origin(
ConvertJavaStringToUTF8(
Java_AutofillProfile_getOrigin(env, jprofile)));
- profile->SetInfo(
- AutofillType(NAME_FULL),
+ profile->SetRawInfo(autofill::NAME_FULL,
Evan Stade 2015/05/15 22:26:45 this one should be SetInfo (note that AutofillOpti
Theresa 2015/05/16 04:37:22 Done.
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getFullName(env, jprofile)));
+ profile->SetRawInfo(autofill::COMPANY_NAME,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getCompanyName(env, jprofile)));
+ profile->SetRawInfo(
+ autofill::ADDRESS_HOME_STREET_ADDRESS,
ConvertJavaStringToUTF16(
- Java_AutofillProfile_getFullName(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(COMPANY_NAME),
+ Java_AutofillProfile_getStreetAddress(env, jprofile)));
+ profile->SetRawInfo(
+ autofill::ADDRESS_HOME_STATE,
+ ConvertJavaStringToUTF16(Java_AutofillProfile_getRegion(env, jprofile)));
+ profile->SetRawInfo(autofill::ADDRESS_HOME_CITY,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getLocality(env, jprofile)));
+ profile->SetRawInfo(
+ autofill::ADDRESS_HOME_DEPENDENT_LOCALITY,
ConvertJavaStringToUTF16(
- Java_AutofillProfile_getCompanyName(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_STREET_ADDRESS),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getStreetAddress(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_STATE),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getRegion(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_CITY),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getLocality(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_DEPENDENT_LOCALITY),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getDependentLocality(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_ZIP),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getPostalCode(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(ADDRESS_HOME_SORTING_CODE),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getSortingCode(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(AutofillType(ADDRESS_HOME_COUNTRY),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getCountryCode(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(PHONE_HOME_WHOLE_NUMBER),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getPhoneNumber(env, jprofile)),
- g_browser_process->GetApplicationLocale());
- profile->SetInfo(
- AutofillType(EMAIL_ADDRESS),
- ConvertJavaStringToUTF16(
- Java_AutofillProfile_getEmailAddress(env, jprofile)),
- g_browser_process->GetApplicationLocale());
+ Java_AutofillProfile_getDependentLocality(env, jprofile)));
+ profile->SetRawInfo(autofill::ADDRESS_HOME_ZIP,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getPostalCode(env, jprofile)));
+ profile->SetRawInfo(autofill::ADDRESS_HOME_SORTING_CODE,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getSortingCode(env, jprofile)));
+ profile->SetRawInfo(autofill::ADDRESS_HOME_COUNTRY,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getCountryCode(env, jprofile)));
+ profile->SetRawInfo(autofill::PHONE_HOME_WHOLE_NUMBER,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getPhoneNumber(env, jprofile)));
+ profile->SetRawInfo(autofill::EMAIL_ADDRESS,
+ ConvertJavaStringToUTF16(
+ Java_AutofillProfile_getEmailAddress(env, jprofile)));
profile->set_language_code(
ConvertJavaStringToUTF8(
Java_AutofillProfile_getLanguageCode(env, jprofile)));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698