Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1139533007: Use SetRawInfo in PersonalDataManagerAndroid::PopulateNativeProfileFromJava (Closed)

Created:
5 years, 7 months ago by Theresa
Modified:
5 years, 7 months ago
Reviewers:
aruslan, Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SetRawInfo in PersonalDataManagerAndroid::PopulateNativeProfileFromJava SetInfo parses phone numbers and gets rid of invalid ones, so SetRawInfo should be used instead. This is consistent with AutofillOptionsHandler::SetAddress BUG=455314 Committed: https://crrev.com/7e9ce57829341d7d31dfa01310ff5d027de39b7a Cr-Commit-Position: refs/heads/master@{#330401}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change name and country code to use SetInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 1 chunk +28 lines, -45 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Theresa
5 years, 7 months ago (2015-05-15 21:21:20 UTC) #2
aruslan
Thanks, lgtm
5 years, 7 months ago (2015-05-15 22:08:38 UTC) #3
Evan Stade
https://codereview.chromium.org/1139533007/diff/1/chrome/browser/autofill/android/personal_data_manager_android.cc File chrome/browser/autofill/android/personal_data_manager_android.cc (right): https://codereview.chromium.org/1139533007/diff/1/chrome/browser/autofill/android/personal_data_manager_android.cc#newcode79 chrome/browser/autofill/android/personal_data_manager_android.cc:79: profile->SetRawInfo(autofill::NAME_FULL, this one should be SetInfo (note that AutofillOptionsHandler ...
5 years, 7 months ago (2015-05-15 22:26:45 UTC) #5
Theresa
ptal - siwthced back to SetInfo for name (for consistency) and country code (for failing ...
5 years, 7 months ago (2015-05-16 04:37:22 UTC) #6
Evan Stade
lgtm
5 years, 7 months ago (2015-05-18 17:40:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139533007/20001
5 years, 7 months ago (2015-05-18 18:38:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139533007/20001
5 years, 7 months ago (2015-05-18 19:29:16 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 20:31:04 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:42:13 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e9ce57829341d7d31dfa01310ff5d027de39b7a
Cr-Commit-Position: refs/heads/master@{#330401}

Powered by Google App Engine
This is Rietveld 408576698