Use FindNSSKeyFromPublicKeyInfoInSlot in GetPrivateKeyOnWorkerThread.

Use FindNSSKeyFromPublicKeyInfoInSlot when a slot is known.

Follow-up to https://codereview.chromium.org/1128153003/. Rather than query all
keys and checking the slot afterwards, just look up keys in the slot directly.

BUG=478777
Committed: https://crrev.com/67840e51e8aa43c3858b3511e41551f1faa9482b
Cr-Commit-Position: refs/heads/master@{#329498}

[davidben, 2015-05-09 00:53:00]

davidben@chromium.org changed reviewers:
+ pneubeck@chromium.org

[pneubeck (no reviews), 2015-05-12 09:48:39]

lgtm with a minor comment

you can also as well drop the BUG=none line or refer to the same bug as the
previous CL.

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:70:
crypto::FindNSSKeyFromPublicKeyInfoInSlot(public_key_vector, slot));
for clarification: this is only equivalent if slot is != nullptr, right?
probably document that at the comment of this function.

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (right):

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:454:
crypto::ScopedSECKEYPrivateKey rsa_key;
great, thanks!

[davidben, 2015-05-12 18:00:42]

davidben@chromium.org changed reviewers:
+ xiyuan@chromium.org

[davidben, 2015-05-12 18:00:43]

+xiyuan for
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1139533002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:70:
crypto::FindNSSKeyFromPublicKeyInfoInSlot(public_key_vector, slot));
On 2015/05/12 09:48:38, pneubeck wrote:
> for clarification: this is only equivalent if slot is != nullptr, right?
> probably document that at the comment of this function.

Done. (There are CHECKs up the call chain, so this should never be null.)

[xiyuan, 2015-05-12 18:03:56]

+tbarzic fyi

LGTM

https://codereview.chromium.org/1139533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1139533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:64:
DCHECK(slot);
nit: This code only runs on real device. So let's CHECK.

[davidben, 2015-05-12 18:05:29]

https://codereview.chromium.org/1139533002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
(right):

https://codereview.chromium.org/1139533002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc:64:
DCHECK(slot);
On 2015/05/12 18:03:55, xiyuan wrote:
> nit: This code only runs on real device. So let's CHECK.

Done. (It's redundant with CHECKs further up the call chain, but having the
check locally is a good plan.)

[davidben, 2015-05-12 18:05:38]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-05-12 18:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
pneubeck@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1139533002/#ps60001
(title: "DCHECK -> CHECK")

[commit-bot: I haz the power, 2015-05-12 18:06:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139533002/60001

[commit-bot: I haz the power, 2015-05-12 18:47:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-12 18:47:20]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2015-05-12 20:57:46]

The CQ bit was checked by davidben@chromium.org

[davidben, 2015-05-12 20:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
pneubeck@chromium.org
Link to the patchset: https://codereview.chromium.org/1139533002/#ps80001
(title: "fix build")

[commit-bot: I haz the power, 2015-05-12 20:58:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139533002/80001

[commit-bot: I haz the power, 2015-05-12 21:38:10]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-12 21:40:03]

Patchset 5 (id:??) landed as
https://crrev.com/67840e51e8aa43c3858b3511e41551f1faa9482b
Cr-Commit-Position: refs/heads/master@{#329498}