Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1139493004: Minor refactor to support experiments in AppListMixer. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@applist-tokenized-exponential
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor refactor to support experiments in AppListMixer. Removed the concept of max_results == 0 meaning "unlimited" in mixer groups. Now, the omnibox group is specifically considered unlimited (and all other groups have a defined maximum). BUG=487494 Committed: https://crrev.com/2579eba5109325886654cef3a87b96f7ba90434d Cr-Commit-Position: refs/heads/master@{#329590}

Patch Set 1 #

Patch Set 2 : Whitespace. #

Patch Set 3 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M chrome/browser/ui/app_list/search/search_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/search/mixer.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/app_list/search/mixer.cc View 1 2 5 chunks +9 lines, -8 lines 0 comments Download
M ui/app_list/search/mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Matt Giuca
5 years, 7 months ago (2015-05-13 02:19:32 UTC) #2
calamity
lgtm
5 years, 7 months ago (2015-05-13 03:14:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139493004/20001
5 years, 7 months ago (2015-05-13 03:15:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/52760)
5 years, 7 months ago (2015-05-13 03:41:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139493004/40001
5 years, 7 months ago (2015-05-13 04:22:26 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 05:18:19 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 05:19:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2579eba5109325886654cef3a87b96f7ba90434d
Cr-Commit-Position: refs/heads/master@{#329590}

Powered by Google App Engine
This is Rietveld 408576698