Initial native keyboard proof of concept.

services/keyboard_native/keyboard_service_impl.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/scoped_ptr.h"

[jamesr, 2015/05/08 23:45:24]

i think you aren't using most of these includes - mind taking a pass to clear
these out?

[APW, 2015/05/09 00:45:59]

Done.

+#include "base/memory/scoped_vector.h"
+#include "base/memory/weak_ptr.h"
+#include "mojo/common/weak_binding_set.h"
+#include "mojo/public/cpp/application/application_connection.h"
+#include "mojo/public/cpp/application/application_delegate.h"
+#include "mojo/public/cpp/application/application_runner.h"
+#include "mojo/public/cpp/application/interface_factory.h"
+#include "mojo/public/cpp/bindings/interface_request.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/services/keyboard/public/interfaces/keyboard.mojom.h"
+
+namespace keyboard {
+
+class KeyboardServiceDelegate : public mojo::ApplicationDelegate,

[jamesr, 2015/05/08 23:45:24]

i would probably move this class and the MojoMain definition into a main.cc and
have only the KeyboardServiceImpl class definition in this file.  we aren't
strictly one-type-per-header but having predictable location for things like
service impls is pretty handy

[APW, 2015/05/09 00:45:59]

Done.

+                                public mojo::InterfaceFactory<KeyboardService> {
+ public:
+  // ApplicationDelegate implementation.
+  bool ConfigureIncomingConnection(
+      mojo::ApplicationConnection* connection) override;
+
+  // InterfaceFactory<KeyboardService> implementation.
+  void Create(mojo::ApplicationConnection* connection,
+              mojo::InterfaceRequest<KeyboardService> request) override;
+};
+
+class KeyboardServiceImpl : public KeyboardService {
+ public:
+  KeyboardServiceImpl(mojo::InterfaceRequest<KeyboardService> handle);

[jamesr, 2015/05/08 23:45:24]

add the 'explicit' keyword for one-argument constructors

i think it's slightly more common to name this parameter 'request'

[APW, 2015/05/09 00:45:59]

Done.

+  ~KeyboardServiceImpl() override;
+
+  // KeyboardService implementation.
+  void Show(KeyboardClientPtr client) override;
+  void ShowByRequest() override;
+  void Hide() override;
+
+ private:
+  mojo::StrongBinding<KeyboardService> strong_binding_;
+};
+
+}  // namespace keyboard