Initial native keyboard proof of concept.

examples/keyboard_client/keyboard_client.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <stdio.h>

[jamesr, 2015/05/08 20:55:15]

don't think you are using this

[APW, 2015/05/08 22:09:28]

Done.

+
+#include "base/logging.h"
+#include "mojo/public/c/system/main.h"
+#include "mojo/public/cpp/application/application_delegate.h"
+#include "mojo/public/cpp/application/application_impl.h"
+#include "mojo/public/cpp/application/application_runner.h"
+#include "mojo/public/cpp/utility/run_loop.h"
+#include "mojo/services/keyboard/public/interfaces/keyboard.mojom.h"
+
+namespace mojo {

[jamesr, 2015/05/08 20:55:15]

please put this in the namespace 'examples', not 'mojo::examples'. a lot of old
stuff is in the namespace mojo but we shouldn't do that for new code

[APW, 2015/05/08 22:09:28]

Done.

+namespace examples {
+
+class KeyboardDelegate : public ApplicationDelegate,
+    public keyboard::KeyboardClient {

[jamesr, 2015/05/08 20:55:15]

this 'public' should be aligned with the previous one. run 'git cl format' and
it'll run clang-format over your code to format it up all pretty

[APW, 2015/05/08 22:09:28]

Done.

+ public:
+
+  keyboard::KeyboardClientPtr mystery_;

[jamesr, 2015/05/08 20:55:15]

put member vars after functions and in the private: section why "mystery"? looks
the same as keyboardClient_ lower down

[APW, 2015/05/08 22:09:28]

Done.

+  mojo::InterfaceRequest<keyboard::KeyboardClient> request_;
+  mojo::Binding<keyboard::KeyboardClient>* binding_;
+
+  void Initialize(ApplicationImpl* app) override {

[jamesr, 2015/05/08 20:55:16]

it's really useful to document what base class a member function is overriding
especially once you have multiple base classes. we have a few different patterns
for this in our codebase but a common one is to have comments like

  // mojo::ApplicationDelegate implementation.
  void Initialize(ApplicationImpl* app) override {
    ...
  }

  // keyboard::KeyboardClient implementation.
  void CommitCompletion(...) override {
    ...
  }

[APW, 2015/05/08 22:09:28]

Done.

+    app->ConnectToService("mojo:keyboard_native", &keyboard_);
+    keyboard_->ShowByRequest();
+    keyboard_->Hide();
+
+    request_ = mojo::GetProxy(&mystery_);

[jamesr, 2015/05/08 20:55:15]

since |request_| is only initialized on this line and then passed away on the
next line you can just use a local

[APW, 2015/05/08 22:09:28]

Done.

+    binding_ = new mojo::Binding<keyboard::KeyboardClient>(this,

[jamesr, 2015/05/08 20:55:16]

there's no need to heap allocate |binding_|. you can make it a member variable,
initialize it with |this| in the KeyboardDelegate constructor and then call
Bind() on it one you have the InterfaceRequest

[APW, 2015/05/08 22:09:28]

Done.

+                                                           request_.Pass());
+
+    keyboard_->Show(mystery_.Pass());
+  }
+
+  void CommitCompletion(keyboard::CompletionDataPtr completion) override {
+  }
+
+  void CommitCorrection(keyboard::CorrectionDataPtr correction) override {
+  }
+
+  void CommitText(const mojo::String& text, int32_t newCursorPosition)
+      override {
+  }
+
+  void DeleteSurroundingText(int32_t beforeLength, int32_t afterLength)
+      override {
+  }
+
+  void SetComposingRegion(int32_t start, int32_t end) override {
+  }
+
+  void SetComposingText(const mojo::String& text, int32_t newCursorPosition)
+      override {
+  }
+
+  void SetSelection(int32_t start, int32_t end) override {
+  }
+
+ private:
+  keyboard::KeyboardServicePtr keyboard_;
+  keyboard::KeyboardClientPtr keyboardClient_;
+};
+
+}  // namespace examples
+}  // namespace mojo
+
+MojoResult MojoMain(MojoHandle application_request) {
+  mojo::ApplicationRunner runner(new mojo::examples::KeyboardDelegate);
+  return runner.Run(application_request);
+}