Set the default action on the title bar menu properly on Windows.

Set the default action on the title bar menu properly on Windows.

It is currently not set, thus chosen by the system. However, the default
action is maximized when the window is not maximized and restore when
the window is maximized.

It is fixing the bug mentioned in bug 260229 as a side effect. The
change is actually applying to all windows, not only Chrome Apps ones.

BUG=260229
TEST=Open Chrome on Windows, right click on the title bar. Look at the
item in bold. Double click. The action should match the name of the item
in bold. Repeat another time.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243300

[sky, 2014-01-06 18:56:55]

"However, the default action is maximized when the window is not maximized and
restore when the window is maximized."

Why should should maximized/restore be the default action?

[mlamouri (slow - plz ping), 2014-01-06 19:21:29]

On 2014/01/06 18:56:55, sky wrote:
> Why should should maximized/restore be the default action?

Isn't it the current behaviour?

[sky, 2014-01-06 20:48:01]

I'm confused as to what 'default action' means in this context? What
is the sequence you do to trigger the 'default action'?

  -Scott

On Mon, Jan 6, 2014 at 11:21 AM,  <mlamouri@chromium.org> wrote:
> On 2014/01/06 18:56:55, sky wrote:
>>
>> Why should should maximized/restore be the default action?
>
>
> Isn't it the current behaviour?
>
> https://codereview.chromium.org/113943005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mlamouri (slow - plz ping), 2014-01-06 22:41:59]

On 2014/01/06 20:48:01, sky wrote:
> I'm confused as to what 'default action' means in this context? What
> is the sequence you do to trigger the 'default action'?

This is the action that happens when you double click on the title bar.

[sky, 2014-01-06 23:34:13]

Ah, ok. In that case, how does this work now? By that I mean double
click on the caption bar toggles maximized/restored already for
non-app windows. What are app windows doing differently that
necessitates this code?

  -Scott

On Mon, Jan 6, 2014 at 2:41 PM,  <mlamouri@chromium.org> wrote:
> On 2014/01/06 20:48:01, sky wrote:
>>
>> I'm confused as to what 'default action' means in this context? What
>> is the sequence you do to trigger the 'default action'?
>
>
> This is the action that happens when you double click on the title bar.
>
> https://codereview.chromium.org/113943005/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mlamouri (slow - plz ping), 2014-01-07 00:27:11]

On 2014/01/06 23:34:13, sky wrote:
> Ah, ok. In that case, how does this work now? By that I mean double
> click on the caption bar toggles maximized/restored already for
> non-app windows. What are app windows doing differently that
> necessitates this code?

This code only changes the UI hint (the action in bold) to match the actual
default action. Windows will put CLOSE in bold by default unless we provide a
default action. With that patch, MAXIMIZE is in bold if the window is not
maximized. Otherwise it is RESTORE. Sublime Text should have a similar behaviour
I believe.

[sky, 2014-01-07 00:48:33]

Ok, LGTM - thanks for helping me understand.

[commit-bot: I haz the power, 2014-01-07 13:27:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/113943005/1

[commit-bot: I haz the power, 2014-01-07 15:29:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mlamouri@chromium.org/113943005/1

[commit-bot: I haz the power, 2014-01-07 15:55:20]

Change committed as 243300