Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1139423002: Add missing application dependency on mandoline/ui/browser/'s mojom target. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing application dependency on mandoline/ui/browser/'s mojom target. I saw this error on a try run: http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/89243/steps/compile/logs/stdio Committed: https://crrev.com/99da121fa1b46bcf122c61eabbdc3c9a981772aa Cr-Commit-Position: refs/heads/master@{#330389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mandoline/ui/browser/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 7 months ago (2015-05-18 16:25:11 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-18 16:54:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139423002/1
5 years, 7 months ago (2015-05-18 16:55:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:15:19 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99da121fa1b46bcf122c61eabbdc3c9a981772aa
Cr-Commit-Position: refs/heads/master@{#330389}

Powered by Google App Engine
This is Rietveld 408576698