VM: Clean up ARM/MIPS breakpoint patching

runtime/vm/debugger_arm.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/code_patcher.h"
 #include "vm/cpu.h"
 #include "vm/debugger.h"
 #include "vm/instructions.h"
 #include "vm/stub_code.h"
 
 namespace dart {
 
 uword CodeBreakpoint::OrigStubAddress() const {
   return saved_value_;
 }
 
 
 void CodeBreakpoint::PatchCode() {
   ASSERT(!is_enabled_);
+  StubCode* stub_code = Isolate::Current()->stub_code();
+  uword stub_target = 0;
+  switch (breakpoint_kind_) {
+    case RawPcDescriptors::kIcCall:
+    case RawPcDescriptors::kUnoptStaticCall:
+      stub_target = stub_code->ICCallBreakpointEntryPoint();
+      break;
+    case RawPcDescriptors::kClosureCall:
+      stub_target = stub_code->ClosureCallBreakpointEntryPoint();
+      break;
+    case RawPcDescriptors::kRuntimeCall:
+      stub_target = stub_code->RuntimeCallBreakpointEntryPoint();
+      break;
+    default:
+      UNREACHABLE();
+  }
   const Code& code = Code::Handle(code_);
-  const Instructions& instrs = Instructions::Handle(code.instructions());
-  Isolate* isolate = Isolate::Current();
-  {
-    WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
-    switch (breakpoint_kind_) {
-      case RawPcDescriptors::kIcCall:
-      case RawPcDescriptors::kUnoptStaticCall: {
-        saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
-        CodePatcher::PatchStaticCallAt(
-            pc_, code, isolate->stub_code()->ICCallBreakpointEntryPoint());
-        break;
-      }
-      case RawPcDescriptors::kClosureCall: {
-        saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
-        CodePatcher::PatchStaticCallAt(
-            pc_, code, isolate->stub_code()->ClosureCallBreakpointEntryPoint());
-        break;
-      }
-      case RawPcDescriptors::kRuntimeCall: {
-        saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
-        CodePatcher::PatchStaticCallAt(
-            pc_, code, isolate->stub_code()->RuntimeCallBreakpointEntryPoint());
-        break;
-      }
-      default:
-        UNREACHABLE();
-    }
-  }
+  saved_value_ = CodePatcher::GetStaticCallTargetAt(pc_, code);
+  CodePatcher::PatchStaticCallAt(pc_, code, stub_target);
   is_enabled_ = true;
 }
 
 
 void CodeBreakpoint::RestoreCode() {
   ASSERT(is_enabled_);
   const Code& code = Code::Handle(code_);
-  const Instructions& instrs = Instructions::Handle(code.instructions());
-  {
-    WritableInstructionsScope writable(instrs.EntryPoint(), instrs.size());
-    switch (breakpoint_kind_) {
-      case RawPcDescriptors::kIcCall:
-      case RawPcDescriptors::kUnoptStaticCall:
-      case RawPcDescriptors::kClosureCall:
-      case RawPcDescriptors::kRuntimeCall: {
-        CodePatcher::PatchStaticCallAt(pc_, code, saved_value_);
-        break;
-      }
-      default:
-        UNREACHABLE();
+  switch (breakpoint_kind_) {
+    case RawPcDescriptors::kIcCall:
+    case RawPcDescriptors::kUnoptStaticCall:
+    case RawPcDescriptors::kClosureCall:
+    case RawPcDescriptors::kRuntimeCall: {
+      CodePatcher::PatchStaticCallAt(pc_, code, saved_value_);
+      break;
     }
+    default:
+      UNREACHABLE();
   }
   is_enabled_ = false;
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM