[iOS] Upstream URL utilities

[iOS] Upstream URL utilities

ios/chrome/browser/chrome_url_util.{h,mm} provides some URL utilities for
use on iOS.

Add missing link dependency on UIKit framework.

BUG=429756
Committed: https://crrev.com/a19f12470cf673998304861961d6c1eb3af2b71b
Cr-Commit-Position: refs/heads/master@{#330356}

[sdefresne, 2015-05-18 13:11:40]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2015-05-18 13:11:40]

Please take a look.

[rohitrao (ping after 24h), 2015-05-18 13:34:56]

Mostly LGTM, bunch of style nits.

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
File ios/chrome/browser/chrome_url_util.mm (right):

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util.mm:48:
base::scoped_nsprotocol<AppIconURLProvider> appIconURLProvider_;
Want to switch to leading underscores for these variables?

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util.mm:83:
@"ssl.gstatic.com/ios-apps/com.google.chrome.ios",
We should consider debranding this.

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
File ios/chrome/browser/chrome_url_util_unittest.mm (right):

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util_unittest.mm:15: GURL
externalURL("uischeme://external-file/foo/bar");
All of the variables in this file should be cplusplus_style?

[sdefresne, 2015-05-18 14:19:54]

Thank you for the review.

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
File ios/chrome/browser/chrome_url_util.mm (right):

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util.mm:48:
base::scoped_nsprotocol<AppIconURLProvider> appIconURLProvider_;
On 2015/05/18 13:34:56, rohitrao wrote:
> Want to switch to leading underscores for these variables?

Done and changed the block to use base::mac::ScopedBlock.

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util.mm:83:
@"ssl.gstatic.com/ios-apps/com.google.chrome.ios",
On 2015/05/18 13:34:56, rohitrao wrote:
> We should consider debranding this.

Added a TODO.

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
File ios/chrome/browser/chrome_url_util_unittest.mm (right):

https://codereview.chromium.org/1139383002/diff/1/ios/chrome/browser/chrome_u...
ios/chrome/browser/chrome_url_util_unittest.mm:15: GURL
externalURL("uischeme://external-file/foo/bar");
On 2015/05/18 13:34:56, rohitrao wrote:
> All of the variables in this file should be cplusplus_style?

Done.

[sdefresne, 2015-05-18 14:20:15]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2015-05-18 14:20:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1139383002/#ps20001
(title: "Address rohitrao comments")

[commit-bot: I haz the power, 2015-05-18 14:20:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1139383002/20001

[commit-bot: I haz the power, 2015-05-18 14:36:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-18 14:36:49]

Patchset 2 (id:??) landed as
https://crrev.com/a19f12470cf673998304861961d6c1eb3af2b71b
Cr-Commit-Position: refs/heads/master@{#330356}

[sdefresne, 2015-05-18 14:45:10]

Thank you for the review.