Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1139323003: Discard duplicate includes of files from storage (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Discard duplicate includes of files from storage/ As any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes). A trivial way to fix these is by removing such an include from the .cc file. So this CL removes all includes from $X.cc files where the $X.h has the same include to confirm to the style guide. BUG=460988 Committed: https://crrev.com/013722c14a62dc525678b3c3b3688f07f0011d23 Cr-Commit-Position: refs/heads/master@{#330693}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M storage/browser/blob/blob_storage_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/database/database_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_file_stream_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_quota_client.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_url.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_usage_cache.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/isolated_context.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/fileapi/local_file_stream_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/native_file_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/sandbox_quota_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/quota/quota_database.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M storage/browser/quota/quota_manager_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/common/fileapi/file_system_util.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Pranay
Hi, PTAL -Thanks Pranay
5 years, 7 months ago (2015-05-19 15:22:42 UTC) #2
piman
lgtm https://codereview.chromium.org/1139323003/diff/1/storage/browser/fileapi/file_system_url_request_job_factory.cc File storage/browser/fileapi/file_system_url_request_job_factory.cc (left): https://codereview.chromium.org/1139323003/diff/1/storage/browser/fileapi/file_system_url_request_job_factory.cc#oldcode8 storage/browser/fileapi/file_system_url_request_job_factory.cc:8: nit: remove extra blank line.
5 years, 7 months ago (2015-05-19 17:50:38 UTC) #3
Pranay
Done..Thanks for the LGTM :) https://codereview.chromium.org/1139323003/diff/1/storage/browser/fileapi/file_system_url_request_job_factory.cc File storage/browser/fileapi/file_system_url_request_job_factory.cc (left): https://codereview.chromium.org/1139323003/diff/1/storage/browser/fileapi/file_system_url_request_job_factory.cc#oldcode8 storage/browser/fileapi/file_system_url_request_job_factory.cc:8: On 2015/05/19 17:50:37, piman ...
5 years, 7 months ago (2015-05-20 02:56:12 UTC) #4
Pranay
Checking CQ bit
5 years, 7 months ago (2015-05-20 03:03:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139323003/20001
5 years, 7 months ago (2015-05-20 03:04:16 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 03:50:32 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 03:51:28 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/013722c14a62dc525678b3c3b3688f07f0011d23
Cr-Commit-Position: refs/heads/master@{#330693}

Powered by Google App Engine
This is Rietveld 408576698