Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 1139263002: Build BoringSSL without assembly if using MSan. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build BoringSSL without assembly if using MSan. MSan requires all code be instrumented. This also rolls BoringSSL. Summary of changes available at: https://boringssl.googlesource.com/boringssl/+log/a07c0fc..9660032 BUG=488708 Committed: https://crrev.com/fc86d6bda541bd5725aa29acec1fe130ec452fe4 Cr-Commit-Position: refs/heads/master@{#330242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -505 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/boringssl/err_data.c View 5 chunks +501 lines, -497 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
5 years, 7 months ago (2015-05-15 22:40:14 UTC) #2
agl
lgtm
5 years, 7 months ago (2015-05-15 22:44:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139263002/1
5 years, 7 months ago (2015-05-16 00:09:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 00:16:39 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc86d6bda541bd5725aa29acec1fe130ec452fe4
Cr-Commit-Position: refs/heads/master@{#330242}

Powered by Google App Engine
This is Rietveld 408576698