Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 1139233002: Revert of Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) (Closed)

Created:
5 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) (patchset #1 id:1 of https://codereview.chromium.org/1130413005/) Reason for revert: This CL most likely breaks Chrome. I can't find any other reason to this issue: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64 Reverting to see if it helps. Original issue's description: > Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151) > > This updates libsrtp to 1.5.2 and uses the OpenSSL/BoringSSL crypto code. > See https://codereview.chromium.org/889083003/ and https://codereview.chromium.org/1098043003/ > > Summary of changes available at: > https://chromium.googlesource.com/chromium/deps/libsrtp/+log/6446144..9c53f85 > > This previously landed in CL 981593002 but got reverted in CL 1131323002 > as it broke the Windows GN bots. The GN script now adds BoringSSL to the > "public_deps" if necessary, so the include path is correct then. > > BUG=328475 > > Committed: https://crrev.com/7c97ef229360cc10cae49569622bdfcba2d43f3c > Cr-Commit-Position: refs/heads/master@{#330066} TBR=jiayl@chromium.org,thakis@chromium.org,juberti@chromium.org,gcasto@chromium.org,jbauch@webrtc.org,mail@joachim-bauch.de NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=328475 Committed: https://crrev.com/c227b52a4245ca5682ec9d88c6ce5ceccec627e5 Cr-Commit-Position: refs/heads/master@{#330070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -56 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/secondary/third_party/libsrtp/BUILD.gn View 8 chunks +3 lines, -55 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Reland: Roll src/third_party/libsrtp 6446144:9c53f85 (svn 292694:295151)
5 years, 7 months ago (2015-05-15 10:25:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139233002/1
5 years, 7 months ago (2015-05-15 10:25:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 10:25:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c227b52a4245ca5682ec9d88c6ce5ceccec627e5 Cr-Commit-Position: refs/heads/master@{#330070}
5 years, 7 months ago (2015-05-15 10:26:51 UTC) #4
henrika (OOO until Aug 14)
FYI, we are now green again after the revert.
5 years, 7 months ago (2015-05-15 11:14:44 UTC) #5
joachim
5 years, 7 months ago (2015-05-15 11:22:57 UTC) #6
Message was sent while issue was closed.
On 2015/05/15 11:14:44, henrika wrote:
> FYI, we are now green again after the revert.

Thanks for the revert. For reference, this was the failed build:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

-----snip-----
Packaging x86_64...
22a23
> libgcc_s.so.1(GCC_3.0)(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64
-----snip-----

Looks like this library is currently only allowed for 32bit, I will create a new
CL which changes this.

Powered by Google App Engine
This is Rietveld 408576698