Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 113923006: Strips leading and trailing whitespace from tooltip (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
Reviewers:
varunjain
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Visibility:
Public.

Description

Strips leading and trailing whitespace from tooltip Windows was automatically doing this for us before. I can't think of a good reason not to do it every where. BUG=331209 TEST=covered by unit test R=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243422

Patch Set 1 #

Patch Set 2 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -1 line) Patch
M ui/views/corewm/tooltip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 chunks +87 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
6 years, 11 months ago (2014-01-07 18:18:29 UTC) #1
varunjain
On 2014/01/07 18:18:29, sky wrote: LGTM
6 years, 11 months ago (2014-01-07 19:02:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/113923006/30001
6 years, 11 months ago (2014-01-07 20:37:36 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 23:00:58 UTC) #4
Message was sent while issue was closed.
Change committed as 243422

Powered by Google App Engine
This is Rietveld 408576698