[Media Router] MediaRouterUI + WebUI handler implementation.

chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_WEBUI_MESSAGE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_WEBUI_MESSAGE_HANDLER_H_
 
+#include <vector>
+
 #include "base/macros.h"
+#include "chrome/browser/ui/webui/media_router/media_cast_mode.h"
+#include "chrome/browser/ui/webui/media_router/media_sink_with_cast_modes.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace base {
 class ListValue;
 }  // namespace base
 
 namespace media_router {
 
+class Issue;
+class MediaRoute;
 class MediaRouterUI;
 
 // The handler for Javascript messages related to the media router dialog.
 class MediaRouterWebUIMessageHandler : public content::WebUIMessageHandler {
  public:
   MediaRouterWebUIMessageHandler();
   ~MediaRouterWebUIMessageHandler() override;
 
   // WebUIMessageHandler implementation.
   void RegisterMessages() override;
 
+  // Updates the list of sinks in the dialog.

[Wez, 2015/05/20 17:51:47]

None of these comments actually add anything; they pretty much mirror the method
names. Suggest a single comment "Methods to update the status displayed by the
dialog." and then have all these methods in one block, with the exception of
UpdateIssue, which needs the ownership of |issue| documenting.

[imcheng (use chromium acct), 2015/05/20 22:01:14]

Done.

+  void UpdateSinks(const std::vector<MediaSinkWithCastModes>& sinks);
+
+  // Updates the list of routes in the dialog.
+  void UpdateRoutes(const std::vector<MediaRoute>& routes);
+
+  // Updates the cast modes in the dialog.
+  void UpdateCastModes(const CastModeSet& cast_modes,
+                       const std::string& source_host);
+
+  // Adds a new route to the dialog.
+  void AddRoute(const MediaRoute& route);
+
+  // Updates the issue to show in the dialog.
+  void UpdateIssue(const Issue* issue);

[Wez, 2015/05/20 17:51:47]

Why const Issue* rather than const Issue& ?

[imcheng (use chromium acct), 2015/05/20 22:01:14]

nullptr is used to indicate there are no more issues.

+
  private:
   // Handlers for JavaScript messages.
   void OnGetInitialSettings(const base::ListValue* args);
   void OnCreateRoute(const base::ListValue* args);
   void OnActOnIssue(const base::ListValue* args);
   void OnCloseRoute(const base::ListValue* args);
   void OnCloseDialog(const base::ListValue* args);
 
   // Helper function for getting a pointer to the corresponding MediaRouterUI.
   MediaRouterUI* GetMediaRouterUI() const;
 
   // Keeps track of whether a command to close the dialog has been issued.
   bool dialog_closing_;
 
   DISALLOW_COPY_AND_ASSIGN(MediaRouterWebUIMessageHandler);
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_UI_WEBUI_MEDIA_ROUTER_MEDIA_ROUTER_WEBUI_MESSAGE_HANDLER_H_