Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1139193003: Speculative fix for ChromeWebViewGuestDelegate crash. (Closed)

Created:
5 years, 7 months ago by wjmaclean
Modified:
5 years, 7 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative fix for ChromeWebViewGuestDelegate crash. It is possible that when ChromeWebViewGuestDelegate::HandleContextMenu() attempts to build a menu to display that it will receive a null pointer (if the associated web_contents' frame tree does not have a focussed frame). In the current code this can lead to a crash. In the short term, while we determine if this lack of a focussed frame is an error or not, early-out if we receive a null menu. BUG=487419 Committed: https://crrev.com/5fca2df48962e5812c8dc438c60434f1bcfae6a1 Cr-Commit-Position: refs/heads/master@{#330326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139193003/1
5 years, 7 months ago (2015-05-15 01:36:23 UTC) #2
wjmaclean
Über-small CL, please take a look.
5 years, 7 months ago (2015-05-15 01:36:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 02:19:44 UTC) #6
Fady Samuel
lgtm
5 years, 7 months ago (2015-05-17 09:23:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139193003/1
5 years, 7 months ago (2015-05-18 03:17:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 04:10:52 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fca2df48962e5812c8dc438c60434f1bcfae6a1
Cr-Commit-Position: refs/heads/master@{#330326}

Powered by Google App Engine
This is Rietveld 408576698