Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1139183002: Flag-protected. Add stateless reject support to crypto streams. (Closed)

Created:
5 years, 7 months ago by ramant (doing other things)
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@QuicCryptoClientConfig_ProcessRejection_92637704
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flag-protected. Add stateless reject support to crypto streams. Client crypto stream: The client now sends all connection options on all handshake messages. (Previously, no options were sent on inchoate hellos). This is so that the client can indicate support for stateless rejects during the initial handshake. If the crypto client stream receives a stateless reject from the server, it will continue validating and cacheing the proof. It will abandon the connection with a special error code immediately thereafter. It will NOT send close messages after a reject, since there is no state at the server to close. (We may have to change this when we do stateless by default). Server crypto stream: The server now processes connection options speculatively on all handshake messages. This is so that the server can detect that the client supports stateless rejects prior to sending the reject itself. It will only consider the options to be "negotiated", however, prior to sending an SHLO. The crypto server stream now also maintains an additional boolean, indicating whether it should use stateless rejects when rejecting messages on the stream ("use_stateless_rejects"). If rejecting, it will only emit a stateless reject if both using stateless rejects and the client supports it. Merge internal change: 92677792 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -130 lines) Patch
M net/quic/quic_crypto_client_stream.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 6 chunks +28 lines, -6 lines 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 5 chunks +45 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 7 chunks +52 lines, -9 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 6 chunks +271 lines, -111 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +63 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 4 chunks +73 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
ramant (doing other things)
5 years, 7 months ago (2015-05-14 21:13:22 UTC) #1
Ryan Hamilton
5 years, 7 months ago (2015-05-15 04:02:22 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698