Issue 1139173002: Revert of Implement support for non-scale/translate CTM in image filters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1139173002: Revert of Implement support for non-scale/translate CTM in image filters. (Closed)

Created:
5 years, 7 months ago by reed1

Modified:
5 years, 7 months ago

Reviewers:
Stephen White, robertphillips, senorblanco, reed2

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Implement support for non-scale/translate CTM in image filters. (patchset #4 id:60001 of https://codereview.chromium.org/1140943004/) Reason for revert: matriximagefilter needs to antialias its draw, so we get smooth diagonals... Original issue's description: > Implement support for non-scale/translate CTM in image filters. > > Clone with tweaks of https://codereview.chromium.org/986623003/ > > pre-cl to guard chrome here: https://codereview.chromium.org/1133403003/ > > BUG=skia:3288 > > Committed: https://skia.googlesource.com/skia/+/35786b176c159d2e7a816e9da9b051ef3129d5cb TBR=robertphillips@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3288 Committed: https://skia.googlesource.com/skia/+/86a17e7716c8db858e219a46b9db3817bb770bee

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -52 lines)			Patch
	M	include/core/SkCanvas.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	src/core/SkCanvas.cpp	View		8 chunks	+6 lines, -50 lines	0 comments	Download

Total messages: 3 (0 generated)

reed1

Created Revert of Implement support for non-scale/translate CTM in image filters.

5 years, 7 months ago (2015-05-14 19:24:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139173002/1

5 years, 7 months ago (2015-05-14 19:25:14 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 19:25:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/86a17e7716c8db858e219a46b9db3817bb770bee