Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 1139163004: Store FP instead of SP in the exit info when transitioning from Dart to C++. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
diff --git a/runtime/vm/stub_code_x64.cc b/runtime/vm/stub_code_x64.cc
index 77da070760a4794b49e7d3275e48af8b7b3dc35e..2dd75a203c1104faa26747e139b2ed1e7e675f1e 100644
--- a/runtime/vm/stub_code_x64.cc
+++ b/runtime/vm/stub_code_x64.cc
@@ -51,7 +51,7 @@ void StubCode::GenerateCallToRuntimeStub(Assembler* assembler) {
// Save exit frame information to enable stack walking as we are about
// to transition to Dart VM C++ code.
- __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RSP);
+ __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RBP);
#if defined(DEBUG)
{ Label ok;
@@ -148,7 +148,7 @@ void StubCode::GenerateCallNativeCFunctionStub(Assembler* assembler) {
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
- __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RSP);
+ __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RBP);
#if defined(DEBUG)
{ Label ok;
@@ -222,7 +222,7 @@ void StubCode::GenerateCallBootstrapCFunctionStub(Assembler* assembler) {
// Save exit frame information to enable stack walking as we are about
// to transition to native code.
- __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RSP);
+ __ movq(Address(R12, Isolate::top_exit_frame_info_offset()), RBP);
#if defined(DEBUG)
{ Label ok;
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698