Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1139123009: Ensure async selections after longpress activate the handles (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
Reviewers:
mohsen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure async selections after longpress activate the handles Fix an issue where the selection handles remain hidden if "empty" selection updates occur after a longpress but before the nonempty selection update. BUG=393025 NOTRY=true Committed: https://crrev.com/9a0d887094a3b66880edf8f48d0065b9ddf4c75e Cr-Commit-Position: refs/heads/master@{#330190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M ui/touch_selection/touch_selection_controller.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ui/touch_selection/touch_selection_controller_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jdduke (slow)
mohsen@: PTAL, thanks. This is pretty bad, as any situation where the renderer main thread ...
5 years, 7 months ago (2015-05-15 18:49:03 UTC) #2
mohsen
LGTM, though this book keeping logic is getting a bit complicated and confusing.
5 years, 7 months ago (2015-05-15 19:42:32 UTC) #3
jdduke (slow)
On 2015/05/15 19:42:32, mohsen wrote: > LGTM, though this book keeping logic is getting a ...
5 years, 7 months ago (2015-05-15 19:51:16 UTC) #4
jdduke (slow)
On 2015/05/15 19:51:16, jdduke wrote: > On 2015/05/15 19:42:32, mohsen wrote: > > LGTM, though ...
5 years, 7 months ago (2015-05-15 19:51:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139123009/1
5 years, 7 months ago (2015-05-15 19:55:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139123009/1
5 years, 7 months ago (2015-05-15 20:48:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 20:56:16 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a0d887094a3b66880edf8f48d0065b9ddf4c75e
Cr-Commit-Position: refs/heads/master@{#330190}

Powered by Google App Engine
This is Rietveld 408576698