Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: src/ports/SkFontConfigParser_android.h

Issue 1139123008: Revert of Font variations. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | src/ports/SkFontConfigParser_android.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkFontConfigParser_android.h
diff --git a/src/ports/SkFontConfigParser_android.h b/src/ports/SkFontConfigParser_android.h
index c1327ff74e177cfb396bd16a90e3f3495b3ad259..dd856bf733da5aa0e234a8b9d5062d9441be3dc2 100644
--- a/src/ports/SkFontConfigParser_android.h
+++ b/src/ports/SkFontConfigParser_android.h
@@ -11,9 +11,6 @@
#include "SkFontMgr_android.h"
#include "SkString.h"
#include "SkTDArray.h"
-
-#include <climits>
-#include <limits>
/** \class SkLanguage
@@ -71,12 +68,6 @@
int fIndex;
int fWeight;
enum class Style { kAuto, kNormal, kItalic } fStyle;
- struct Axis {
- Axis() : fTag(SkSetFourByteTag('\0','\0','\0','\0')), fValue(0) { }
- SkFourByteTag fTag;
- SkFixed fValue;
- };
- SkSTArray<4, Axis, true> fAxes;
};
/**
@@ -117,100 +108,4 @@
} // SkFontConfigParser namespace
-
-/** Parses a null terminated string into an integer type, checking for overflow.
- * http://www.w3.org/TR/html-markup/datatypes.html#common.data.integer.non-negative-def
- *
- * If the string cannot be parsed into 'value', returns false and does not change 'value'.
- */
-template <typename T> static bool parse_non_negative_integer(const char* s, T* value) {
- SK_COMPILE_ASSERT(std::numeric_limits<T>::is_integer, T_must_be_integer);
-
- if (*s == '\0') {
- return false;
- }
-
- const T nMax = std::numeric_limits<T>::max() / 10;
- const T dMax = std::numeric_limits<T>::max() - (nMax * 10);
- T n = 0;
- for (; *s; ++s) {
- // Check if digit
- if (*s < '0' || '9' < *s) {
- return false;
- }
- T d = *s - '0';
- // Check for overflow
- if (n > nMax || (n == nMax && d > dMax)) {
- return false;
- }
- n = (n * 10) + d;
- }
- *value = n;
- return true;
-}
-
-/** Parses a null terminated string into a signed fixed point value with bias N.
- *
- * Like http://www.w3.org/TR/html-markup/datatypes.html#common.data.float-def ,
- * but may start with '.' and does not support 'e'. '-?((:digit:+(.:digit:+)?)|(.:digit:+))'
- *
- * Checks for overflow.
- * Low bit rounding is not defined (is currently truncate).
- * Bias (N) required to allow for the sign bit and 4 bits of integer.
- *
- * If the string cannot be parsed into 'value', returns false and does not change 'value'.
- */
-template <int N, typename T> static bool parse_fixed(const char* s, T* value) {
- SK_COMPILE_ASSERT(std::numeric_limits<T>::is_integer, T_must_be_integer);
- SK_COMPILE_ASSERT(std::numeric_limits<T>::is_signed, T_must_be_signed);
- SK_COMPILE_ASSERT(sizeof(T) * CHAR_BIT - N >= 5, N_must_leave_four_bits_plus_sign);
-
- bool negate = false;
- if (*s == '-') {
- ++s;
- negate = true;
- }
- if (*s == '\0') {
- return false;
- }
-
- const T nMax = (std::numeric_limits<T>::max() >> N) / 10;
- const T dMax = (std::numeric_limits<T>::max() >> N) - (nMax * 10);
- T n = 0;
- T frac = 0;
- for (; *s; ++s) {
- // Check if digit
- if (*s < '0' || '9' < *s) {
- // If it wasn't a digit, check if it is a '.' followed by something.
- if (*s != '.' || s[1] == '\0') {
- return false;
- }
- // Find the end, verify digits.
- for (++s; *s; ++s) {
- if (*s < '0' || '9' < *s) {
- return false;
- }
- }
- // Read back toward the '.'.
- for (--s; *s != '.'; --s) {
- T d = *s - '0';
- frac = (frac + (d << N)) / 10; // This requires four bits overhead.
- }
- break;
- }
- T d = *s - '0';
- // Check for overflow
- if (n > nMax || (n == nMax && d > dMax)) {
- return false;
- }
- n = (n * 10) + d;
- }
- if (negate) {
- n = -n;
- frac = -frac;
- }
- *value = (n << N) + frac;
- return true;
-}
-
#endif /* SKFONTCONFIGPARSER_ANDROID_H_ */
« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | src/ports/SkFontConfigParser_android.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698