Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1139123006: Fork the mojo shell interfaces used by Mandoline. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, kalyank, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, extensions-reviews_chromium.org, dcheng, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fork the mojo shell interfaces used by Mandoline. Per in-person discussions, as long as we have a fork of mojo shell we'll fork the interfaces. I'll do third_party/mojo/src/mojo/public/java/application in a followup. TBR=tsepez Committed: https://crrev.com/05a3de409c2653028aede6a467bb70c0addf57fc Cr-Commit-Position: refs/heads/master@{#329965}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fixes and landmine #

Patch Set 5 : fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -2157 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/clipboard_application_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/clipboard/clipboard_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_document.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/html_viewer/html_document.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/html_viewer/setup.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_media_player_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/native_viewport/main.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/native_viewport/native_viewport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/resource_provider/public/interfaces/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/surfaces/surfaces_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/surfaces/surfaces_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/display_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/view_manager/public/cpp/lib/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_client_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_client_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/view_manager/public/cpp/lib/view_manager_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/view.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/view_manager_client_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/view_manager_context.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/view_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_client_apptest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/view_manager/view_manager_service_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/window_manager/public/interfaces/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/window_manager/window_manager_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/window_manager/window_manager_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/window_manager/window_manager_apptest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/window_manager/window_manager_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/application_setup.mojom View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A content/common/mojo/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/render_frame_setup.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M content/utility/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 2 chunks +1 line, -1 line 0 comments Download
A extensions/browser/mojo/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/mojo/stash_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions_tests.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/browser/browser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mandoline/ui/browser/merged_service_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/test/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/application/application_runner_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/application_test_base_chromium.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/application_test_base_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/application/public/cpp/BUILD.gn View 6 chunks +12 lines, -7 lines 0 comments Download
A + mojo/application/public/cpp/application_connection.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/application/public/cpp/application_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/application_impl.h View 2 chunks +9 lines, -8 lines 0 comments Download
A + mojo/application/public/cpp/application_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/application_test_base.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/application/public/cpp/connect.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/application/public/cpp/interface_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/interface_factory_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/application/public/cpp/lazy_interface_ptr.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/application/public/cpp/lib/application_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/application/public/cpp/lib/application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/application/public/cpp/lib/application_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/lib/application_runner.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/lib/application_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/application/public/cpp/lib/application_test_main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/application/public/cpp/lib/interface_factory_connector.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/application/public/cpp/lib/service_connector_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/lib/service_connector_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/application/public/cpp/lib/service_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/application/public/cpp/lib/service_registry.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + mojo/application/public/cpp/lib/service_registry.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/application/public/cpp/service_connector.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/application/public/cpp/service_provider_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A mojo/application/public/cpp/tests/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A + mojo/application/public/cpp/tests/service_registry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/application/public/interfaces/BUILD.gn View 1 chunk +4 lines, -7 lines 0 comments Download
A + mojo/application/public/interfaces/application.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/application/public/interfaces/service_provider.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/application/public/interfaces/shell.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/common/trace_controller_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/common/tracing_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/tracing_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +88 lines, -2 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/android/android_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/android/android_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/android_handler_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/background_application_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/android/native_viewport_application_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/android/native_viewport_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/shell_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/test/pingable_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A mojo/services/test_service/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_application.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/tracing_app.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/tracing/tracing_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/shell/native_runner.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/rev_sdk.py View 2 chunks +13 lines, -0 lines 1 comment Download
M third_party/mojo/mojo_edk_tests.gyp View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 chunk +0 lines, -70 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/BUILD.gn View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/application_connection.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/application_delegate.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/application_impl.h View 1 chunk +0 lines, -139 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/application_runner.h View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/application_test_base.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/connect.h View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/interface_factory.h View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/interface_factory_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lazy_interface_ptr.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_connection.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_delegate.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_runner.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/application_test_main.cc View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/interface_factory_connector.h View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_connector_registry.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_connector_registry.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_provider_impl.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_registry.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/lib/service_registry.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/service_connector.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/service_provider_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/tests/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/mojo/src/mojo/public/cpp/application/tests/service_registry_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +0 lines, -50 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/application/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/application/application.mojom View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/application/service_provider.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/mojo/src/mojo/public/interfaces/application/shell.mojom View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo_services/src/content_handler/public/interfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo_services/src/content_handler/public/interfaces/content_handler.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
jam
5 years, 7 months ago (2015-05-14 21:54:29 UTC) #2
Ben Goodger (Google)
rubber stamp lgtm
5 years, 7 months ago (2015-05-14 22:09:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139123006/80001
5 years, 7 months ago (2015-05-14 22:18:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63778)
5 years, 7 months ago (2015-05-14 22:28:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139123006/80001
5 years, 7 months ago (2015-05-14 22:43:42 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-14 22:56:20 UTC) #10
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/05a3de409c2653028aede6a467bb70c0addf57fc Cr-Commit-Position: refs/heads/master@{#329965}
5 years, 7 months ago (2015-05-14 22:57:05 UTC) #11
jamesr
5 years, 7 months ago (2015-05-22 21:25:03 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1139123006/diff/80001/mojo/tools/rev_sdk.py
File mojo/tools/rev_sdk.py (right):

https://codereview.chromium.org/1139123006/diff/80001/mojo/tools/rev_sdk.py#n...
mojo/tools/rev_sdk.py:24: "mojo/public/cpp/application",
Removing these files from the copy of the SDK in chromium means that it is
impossible to build a mojo application from the chromium repository at all, even
for projects that might want to support running in both mandoline and mojo
shells.  Is this deliberate?

Powered by Google App Engine
This is Rietveld 408576698