Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: sky/framework/components/drawer_header.dart

Issue 1139123005: [Effen] Remove 'display' from drawer_header.dart. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: base is now checked in Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/components/drawer_header.dart
diff --git a/sky/framework/components/drawer_header.dart b/sky/framework/components/drawer_header.dart
index c1c1d528372423d38ca750fc6e2cc09ae5bf7c3d..ba3aae6d95eea5fde1801d15591aa031bee97acd 100644
--- a/sky/framework/components/drawer_header.dart
+++ b/sky/framework/components/drawer_header.dart
@@ -3,24 +3,20 @@
// found in the LICENSE file.
import '../fn.dart';
+import '../layout.dart';
import '../theme/colors.dart';
import '../theme/view_configuration.dart';
class DrawerHeader extends Component {
static final Style _style = new Style('''
- display: flex;
- flex-direction: column;
height: ${140 + kStatusBarHeight}px;
- -webkit-user-select: none;
background-color: ${BlueGrey[50]};
border-bottom: 1px solid #D1D9E1;
padding-bottom: 7px;
margin-bottom: 8px;'''
);
- static final Style _spacerStyle = new Style('''
- flex: 1'''
- );
+ static final FlexBoxParentData _spacerParentData = new FlexBoxParentData()..flex = 1;
static final Style _labelStyle = new Style('''
padding: 0 16px;'''
@@ -31,12 +27,13 @@ class DrawerHeader extends Component {
DrawerHeader({ Object key, this.children }) : super(key: key);
UINode build() {
- return new Container(
+ return new FlexContainer(
+ direction: FlexDirection.Column,
style: _style,
children: [
- new Container(
- key: 'Spacer',
- style: _spacerStyle
+ new ParentDataNode(
+ new Container(key: 'Spacer'),
+ _spacerParentData
),
new Container(
key: 'Label',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698